Patch #22128

Attachment form too wide on small screens

Added by Gregor Schmidt about 2 years ago. Updated about 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI - Responsive
Target version:3.2.1

Description

When uploading attachments to Redmine (issues, wiki pages or documents) using small screens, then the progress bar and the optional description field do not fit on the screen. Attached you may find a patch proposing a fix.

Before

erroneous state

"Optional description" field is partially hidden. Delete attachment is totally hidden.

After

proposed fix

Upload and description are now on separate rows. The delete icon is moved to the top right corner, where it is clear, that it belongs to the whole block - similar to the (x) in window systems. There is also added white space between multiple attachments to make sure, that the input grouping is clear to the user.

screen-capture-43.png - erroneous state (34.4 KB) Gregor Schmidt, 2016-03-02 15:00

screen-capture-42.png - proposed fix (39.5 KB) Gregor Schmidt, 2016-03-02 15:08

0001-Update-alignment-of-attachment-upload-form-for-small.patch Magnifier - Patch file (1002 Bytes) Gregor Schmidt, 2016-03-02 15:11

Associated revisions

Revision 15218
Added by Jean-Philippe Lang about 2 years ago

Update alignment of attachment upload form for small screens (#22128).

Patch by Gregor Schmidt.

History

#1 Updated by Go MAEDA about 2 years ago

  • Assignee set to Jan from Planio www.plan.io
  • Target version set to Candidate for next minor release

It works fine for me.
@Jan, could you review this patch?

#2 Updated by Jan from Planio www.plan.io about 2 years ago

  • Status changed from New to Resolved
  • Assignee deleted (Jan from Planio www.plan.io)

Gregor works for Planio at the moment and his contributions are sponsored by Planio, so the patch has already been reviewed by us in-house. The patch is good, I am setting it to resolved – just needs a merge. Thanks!

#3 Updated by Go MAEDA about 2 years ago

  • Status changed from Resolved to New
  • Target version changed from Candidate for next minor release to 3.2.1

Thanks, Jan. Setting target version to 3.2.1.

#4 Updated by Jean-Philippe Lang about 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Merged in 3.2, thanks.

Also available in: Atom PDF