Patch #22278

Revision Graph and Table should work with vertical-align: middle

Added by Gregor Schmidt almost 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.2

Description

The revision list and the Raphael based graph next to it, are currently assumed to be vertical-align: top, i.e. the dots representing the commits are always positioned at the top of the table cell. This is a limitation for theme authors. Planio e.g. restyled the table to use vertical-align: middle but now the dots are misplaced.

The patch attached inspects the currently used css properties to properly calculate the dot's position. The patch is targeted at current trunk r15251.

0001-Check-for-vertical-align-when-computing-positions-in.patch Magnifier (2.28 KB) Gregor Schmidt, 2016-03-17 15:52

theme-without-patch.png (67.3 KB) Gregor Schmidt, 2016-03-25 12:53

theme-with-patch.png (67.7 KB) Gregor Schmidt, 2016-03-25 12:54

default-with-patch.png (67.1 KB) Gregor Schmidt, 2016-03-25 12:54

planio-with-patch.png (49.3 KB) Gregor Schmidt, 2016-03-25 13:01

Associated revisions

Revision 15299
Added by Jean-Philippe Lang almost 2 years ago

Revision Graph and Table should work with vertical-align: middle (#22278).

Patch by Gregor Schmidt.

History

#1 Updated by Go MAEDA almost 2 years ago

  • Category changed from Themes to UI

Thanks for the patch. Could you show screenshots of the effect of this patch?

#2 Updated by Gregor Schmidt almost 2 years ago

Sure, here we go!

For "educational purpose" I've created a simple theme with the following application.css

@import url(../../../stylesheets/application.css);

table.changesets td {
  vertical-align: middle;
}

Using this theme and the current Redmine trunk, I get the following revision table

Using the patch, I get the following

while the default theme still looks as expected

This example theme does not make a lot of sense on its own. It was just created for testing. But e.g. Planio's new design uses vertical-align: middle for its tables. (Planio already has the patch applied.)

#3 Updated by Go MAEDA almost 2 years ago

  • Target version set to 3.2.2

Thanks, I understand.
Setting target version to 3.2.2.

#4 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Also available in: Atom PDF