Project

General

Profile

Actions

Patch #22278

closed

Revision Graph and Table should work with vertical-align: middle

Added by Gregor Schmidt about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The revision list and the Raphael based graph next to it, are currently assumed to be vertical-align: top, i.e. the dots representing the commits are always positioned at the top of the table cell. This is a limitation for theme authors. Planio e.g. restyled the table to use vertical-align: middle but now the dots are misplaced.

The patch attached inspects the currently used css properties to properly calculate the dot's position. The patch is targeted at current trunk r15251.


Files

0001-Check-for-vertical-align-when-computing-positions-in.patch (2.28 KB) 0001-Check-for-vertical-align-when-computing-positions-in.patch Gregor Schmidt, 2016-03-17 15:52
theme-without-patch.png (67.3 KB) theme-without-patch.png Gregor Schmidt, 2016-03-25 12:53
theme-with-patch.png (67.7 KB) theme-with-patch.png Gregor Schmidt, 2016-03-25 12:54
default-with-patch.png (67.1 KB) default-with-patch.png Gregor Schmidt, 2016-03-25 12:54
planio-with-patch.png (49.3 KB) planio-with-patch.png Gregor Schmidt, 2016-03-25 13:01
Actions

Also available in: Atom PDF