Defect #22532

Strip whitespace from login on login page

Added by Artur Borisovich about 2 years ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Accounts / authentication
Target version:3.4.4
Resolution:Fixed Affected version:

Description

Spaces in login is removed before user account will saved. But when you try to login you made a mistake like whitespace before login or after it will be not you login.

Redmine 2016-04-17 00-27-49.png (15 KB) Artur Borisovich, 2016-04-16 23:28

Added_login_trimming_spaces_for_authentication.patch Magnifier (600 Bytes) Artur Borisovich, 2016-04-16 23:53

test_login_should_strip_whitescapes_from_user_name.diff Magnifier (677 Bytes) Marius BALTEANU, 2017-12-10 13:20


Related issues

Related to Redmine - Defect #27754: Strip whitespace from email addresses on lost password page Closed

Associated revisions

Revision 17113
Added by Go MAEDA 5 months ago

Strip whitespace from login on login page (#22532).

Patch by Artur Borisovich and Marius BALTEANU.

Revision 17114
Added by Go MAEDA 5 months ago

Merged r17113 to 3.4-stable (#22532).

History

#2 Updated by Toshi MARUYAMA about 2 years ago

  • Category set to Accounts / authentication

#3 Updated by Marius BALTEANU 5 months ago

  • Related to Defect #27754: Strip whitespace from email addresses on lost password page added

#4 Updated by Go MAEDA 5 months ago

  • Target version set to 3.4.4

Marius BALTEANU wrote in #27754#note-7:

I think that we should fix also the related issue (#22532) because is almost on the same topic.

I agree with Marius. I think it would be better to deliver this fix along with #27754.
Setting target version to 3.4.4.

#5 Updated by Marius BALTEANU 5 months ago

The patch attached by Artur Borisovich still applies cleanly. I've added a test for it and I think that we can fix this issue.

#6 Updated by Go MAEDA 5 months ago

LGTM. I will commit this fix within a few days.

#7 Updated by Go MAEDA 5 months ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed to the trunk. Thank you.

#8 Updated by Go MAEDA 5 months ago

  • Subject changed from Spaces are not removed when the login authorization to Strip whitespace from login on login page
  • Status changed from Resolved to Closed

Merged to 3.4-stable.

#9 Updated by Artur Borisovich 5 months ago

Go MAEDA wrote:

Merged to 3.4-stable.

Nice, thank you.

Also available in: Atom PDF