Patch #23346

Set user's localization before redirecting on forced password change to generate flash message in current user's language

Added by Holger Just 9 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:I18n
Target version:3.3.1

Description

If a user is forced to change their password on login, they get redirected to a password change form with a flash message set. The flash message however is generated using the locale of the previous request since the current localization is only set to i18n after the redirect. When multiple users with dirrferent languages are using a Redmine, the flash message can thus be shown in an unexpected language.

The attached patch against the current trunk fixes this behavior by setting the language before checking for a forced password change.

0001-Set-user-s-localization-before-redirecting-to-passwo.patch Magnifier (1.04 KB) Holger Just, 2016-07-15 12:57

Associated revisions

Revision 15775
Added by Jean-Philippe Lang 7 months ago

Set user's localization before redirecting (#23346).

Patch by Holger Just.

Revision 15776
Added by Jean-Philippe Lang 7 months ago

Adds a test for #23346.

History

#1 Updated by Go MAEDA 7 months ago

  • Target version set to 3.3.1

#2 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed, thanks.

Also available in: Atom PDF