Patch #24649

Make Spent time clickable in issue lists

Added by Olivier Houdas 8 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues list
Target version:3.4.0

Description

In Issue lists, User, Version or Project fields are clickable to take the user to the relevant page, and not to the issue page itself.

It would make sense to also make the Spent time values clickable to take the user to the details of the logged time.

A patch to do it is attached.

Clickable-spent-time-in-issue-lists-Redmine-3.3.1.patch Magnifier - Patch based on Redmine 3.3.1 (881 Bytes) Olivier Houdas, 2016-12-19 17:43

Clickable-spent-time-in-issue-lists-Redmine-trunk-2016-12-14.patch Magnifier (730 Bytes) Olivier Houdas, 2017-01-02 10:16

clickable-spent-time-in-issue-lists-v3.diff Magnifier (874 Bytes) Go MAEDA, 2017-01-09 05:19

spent-time-clickable.png (12 KB) Go MAEDA, 2017-01-13 02:32

after-clicking-spent-time.png (33.3 KB) Go MAEDA, 2017-01-13 02:32

after-clicking-total-spent-time.png (51 KB) Go MAEDA, 2017-01-13 02:32

Associated revisions

Revision 16204
Added by Jean-Philippe Lang 7 months ago

Make Spent time clickable in issue lists (#24649).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA 8 months ago

Thank you for submitting the patch but it cannot be applied cleanly to the current trunk (r16111).
source:trunk/app/helpers/queries_helper.rb@16101#L192

#2 Updated by Olivier Houdas 8 months ago

OK, in that case, the patch would be as attached (sorry, I'm using Mercurial, so I'm a bit behind the subversion commits)

#3 Updated by Go MAEDA 8 months ago

Since the patch by Olivier Houdas cannot be applied to the current trunk (r16166) for the following reasons, I have updated the patch.

  • The variable name "issue" was renamed to "item" by #24643
  • issue_time_entries_path for GET request has been droped in r15644

And changed link destination for "Spent time" and "Total spent time".

  • "Spent time" -> /projects/xxx/time_entries?issue_id=nn (Issue is #nn)
  • "Total spent time" -> /projects/xxx/time_entries?issue_id=nn (Issue contains #nn)

#4 Updated by Go MAEDA 7 months ago

I suggest including this feature in Redmine 3.4.0.


Clickable spent time in issues list:


After clicking on spent time:
Users are navigated to: /projects/xxx/time_entries?issue_id=nn (Issue is #nn)


After clicking on total spent time:
Users are navigated to: /projects/xxx/time_entries?issue_id=nn (Issue contains #nn)

#5 Updated by Robert Korulczyk 7 months ago

Related: #20661

#6 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed, thanks.

Also available in: Atom PDF