Project

General

Profile

Actions
Copy link

Patch #24776

closed

UI inconsistencies on /enumerations/index view

Added by Mischa The Evil over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
UI
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Coming out of and a follow-up to #24720. I spotted three things that could benefit improvement:
  • re-position the new enumeration links to above the item tables (in line with #24720 changes)
  • add 'icon' and 'icon-add' classes to the new enumeration links (like most, if not all, new ... links in both the front- and the back-end) to make them stand-out more
  • handle cases of none existing enumerations using the regular no-data message blocks

I attach three patches implementing these changes. This patch serial, against current source:/trunk@16156, is produced using git format-patch which makes the individual patches apply-able using "patch -p1 < 0001-...".

Files

Download all files
before.png (19.2 KB) before.png Mischa The Evil, 2017-01-07 18:57
after.png (27.4 KB) after.png Mischa The Evil, 2017-01-07 18:58
before-add-margin.png (20 KB) before-add-margin.png Go MAEDA, 2017-01-09 13:12
after-add-margin.png (21.2 KB) after-add-margin.png Go MAEDA, 2017-01-09 13:12
rare-case-indifferent-distance.png (33.7 KB) rare-case-indifferent-distance.png Mischa The Evil, 2017-01-10 06:56
extreme-case.png (12.9 KB) extreme-case.png Mischa The Evil, 2017-01-10 06:56
0001-Move-New-enumeration-links-to-above-the-item-tables.patch (1.01 KB) 0001-Move-New-enumeration-links-to-above-the-item-tables.patch Mischa The Evil, 2017-01-10 07:30
0002-Add-icon-and-icon-add-classes-to-new-enum-links.patch (893 Bytes) 0002-Add-icon-and-icon-add-classes-to-new-enum-links.patch Mischa The Evil, 2017-01-10 07:30
0003-Handle-the-case-of-none-existing-enumerations-using-.patch (699 Bytes) 0003-Handle-the-case-of-none-existing-enumerations-using-.patch Mischa The Evil, 2017-01-10 07:30
0004-Add-margin-between-tables-and-the-following-headings.patch (1.04 KB) 0004-Add-margin-between-tables-and-the-following-headings.patch Mischa The Evil, 2017-01-10 07:30

Related issues

Related to Redmine - Feature #24720: Move all 'new item' links in project settings to above the item tablesClosedJean-Philippe Lang

Actions
Actions
Copy link
 #1

Updated by Mischa The Evil over 7 years ago

Some comparative screenshots.

Before:

After:

Actions
Copy link
 #2

Updated by Mischa The Evil over 7 years ago

  • Related to Feature #24720: Move all 'new item' links in project settings to above the item tables added
Actions
Copy link
 #3

Updated by Go MAEDA over 7 years ago

Nice improvement.

But I think it would be better to set more margin between the table and the next heading. Please see the following screenshots.

current patch:

set more margin:

Actions
Copy link
 #4

Updated by Mischa The Evil over 7 years ago

Go MAEDA wrote:

But I think it would be better to set more margin between the table and the next heading. Please see the following screenshots.

I totally agree. Thanks for reviewing and your feedback. I'll leave an updated, rebased patch set — against source:/trunk@16171 — adding a fourth patch containing the CSS rule you've proposed. The first three patches didn't change by content, only its metadata.

Regarding the CSS rule: while it fixes practical all cases1, it does leave a difference between the space between the tables and the following headers ánd the space between the paragraphs and the following headers. See the following two screenshots:

  • Remaining difference made visual:
  • Extreme case without any enumerations at all:

This cannot be fixed easily (and in a clean way) due to the current structure of the page. Though, given the rarity of the case, I think I can live with this minor drawback/trade-off. But, YMMV...

1 I've almost never seen Redmine instances in production without enumerations, only just installed ones where no default data was loaded yet.

Actions
Copy link
 #5

Updated by Mischa The Evil over 7 years ago

  • File deleted (0001-Move-New-enumeration-links-to-above-the-item-tables.patch)
Actions
Copy link
 #6

Updated by Mischa The Evil over 7 years ago

  • File deleted (0002-Add-icon-and-icon-add-classes-to-new-enum-links.patch)
Actions
Copy link
 #7

Updated by Mischa The Evil over 7 years ago

  • File deleted (0003-Handle-the-case-of-none-existing-enumerations-using-.patch)
Actions
Copy link
 #8

Updated by Go MAEDA over 7 years ago

  • Target version changed from Candidate for next major release to 3.4.0

Mischa The Evil wrote:

Regarding the CSS rule: while it fixes practical all cases1, it does leave a difference between the space between the tables and the following headers ánd the space between the paragraphs and the following headers. See the following two screenshots:

Looks good to me. Thanks!
I think this issue is now ready to be merged. Setting target version to 3.4.0.

1 I've almost never seen Redmine instances in production without enumerations, only just installed ones where no default data was loaded yet.

Absolutely agree.

Actions
Copy link
 #9

Updated by Jean-Philippe Lang over 7 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed, thanks Mischa.

Actions
Copy link

Also available in: Atom PDF