Defect #26667
closed
Filtering time entries after issue's target version doesn't work as expected in some cases
0%
Description
1. Target version select is empty when you add the issue's target version filter
To reproduce:
- Open spent time tab from a project
- Add the Issue's target version filter
- Observe that the dropdown is empty.
If you apply the query, a validation message will appear and the dropdown gets populated.
2. Filtering time entries after multiple target version filters only after the first version.
To reproduce:
- performe de above steps and apply the query
- expand the Target version select to multiselect
- select two versions that have issues with time entries.
- apply the query
- observe that only the time entries related to the issues from first version are returned.
Attached are two patches that fix these 2 issues.
Files
Related issues
Updated by Go MAEDA over 6 years ago
Thank you for finding the probelem. But I think that the root cause of the problem is that TimeEntryQuery#project returns nil instead of the current project. Because of this, subproject dropdown also is not working.
Updated by Go MAEDA over 6 years ago
It seems that the drop-down have been broken by r16170.
Updated by Marius BĂLTEANU over 6 years ago
- File fix_project_on_time_entry_query_filter.patch fix_project_on_time_entry_query_filter.patch added
Go MAEDA wrote:
Thank you for finding the probelem. But I think that the root cause of the problem is that TimeEntryQuery#project returns nil instead of the current project. Because of this, subproject dropdown also is not working.
Indeed, you're right. Here is a patch that fixes this. It can be applied before or after my previous patches.
fix_filter_values_for_fixed_version_id.patch remains a valid patch because that if is not required, fixed_version_values already checks if the project is defined or not.
Updated by Marius BĂLTEANU over 6 years ago
- File add_subproject_filter_test_for_time_entries.patch add_subproject_filter_test_for_time_entries.patch added
Added a test also for subproject filter values. It should be applied after my previous patches.
Considering that these issues are quite important, maybe is a good idea to release soon the 3.4.3 version (which has other important fixes).
Updated by Go MAEDA over 6 years ago
Marius, thank you for submitting updated patches. Those are works fine for me.
Updated by Go MAEDA over 6 years ago
- Related to Feature #13558: Add version filter in spent time report added
Updated by Maxim Krušina over 6 years ago
- Has duplicate Defect #27117: Cannot select versions in Spent time report added
Updated by Jean-Philippe Lang over 6 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed, thanks.
Updated by Marius BĂLTEANU over 6 years ago
Jean-Philippe Lang, in this ticket there are 2 more patches that should be committed in my opinion:
1. fix_filter_values_for_fixed_version_id.patch which removes an unnecessary if and adds a test for the first problem reported by me. If you consider that if necessary, we could commit at least the test.
2. fix_filter_after_multiple_version_ids.patch which fixes the second problem reported by me in this ticket.
Updated by Jean-Philippe Lang over 6 years ago
Sorry, both patches are also committed, thanks.
Updated by Marius BĂLTEANU over 6 years ago
Jean-Philippe Lang wrote:
Sorry, both patches are also committed, thanks.
No problem, thanks for committing these patches.