Defect #26667

Filtering time entries after issue's target version doesn't work as expected in some cases

Added by Marius BALTEANU about 1 month ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Time tracking
Target version:3.4.3
Resolution: Affected version:3.4.2

Description

1. Target version select is empty when you add the issue's target version filter
To reproduce:
- Open spent time tab from a project
- Add the Issue's target version filter
- Observe that the dropdown is empty.

If you apply the query, a validation message will appear and the dropdown gets populated.

2. Filtering time entries after multiple target version filters only after the first version.
To reproduce:
- performe de above steps and apply the query
- expand the Target version select to multiselect
- select two versions that have issues with time entries.
- apply the query
- observe that only the time entries related to the issues from first version are returned.

Attached are two patches that fix these 2 issues.

fix_filter_values_for_fixed_version_id.patch Magnifier (1.55 KB) Marius BALTEANU, 2017-08-11 16:29

fix_filter_after_multiple_version_ids.patch Magnifier (1.83 KB) Marius BALTEANU, 2017-08-11 16:30

subproject-dropdown-is-not-working@2x.png (21 KB) Go MAEDA, 2017-08-12 03:21

fix_project_on_time_entry_query_filter.patch Magnifier (494 Bytes) Marius BALTEANU, 2017-08-20 11:47

add_subproject_filter_test_for_time_entries.patch Magnifier (962 Bytes) Marius BALTEANU, 2017-08-20 12:15


Related issues

Related to Redmine - Feature #13558: Add version filter in spent time report Closed

History

#1 Updated by Go MAEDA about 1 month ago

Thank you for finding the probelem. But I think that the root cause of the problem is that TimeEntryQuery#project returns nil instead of the current project. Because of this, subproject dropdown also is not working.

#2 Updated by Go MAEDA about 1 month ago

It seems that the drop-down have been broken by r16170.

#3 Updated by Go MAEDA about 1 month ago

  • Target version set to 3.4.3

#4 Updated by Marius BALTEANU about 1 month ago

Go MAEDA wrote:

Thank you for finding the probelem. But I think that the root cause of the problem is that TimeEntryQuery#project returns nil instead of the current project. Because of this, subproject dropdown also is not working.

Indeed, you're right. Here is a patch that fixes this. It can be applied before or after my previous patches.

fix_filter_values_for_fixed_version_id.patch remains a valid patch because that if is not required, fixed_version_values already checks if the project is defined or not.

#5 Updated by Marius BALTEANU about 1 month ago

Added a test also for subproject filter values. It should be applied after my previous patches.

Considering that these issues are quite important, maybe is a good idea to release soon the 3.4.3 version (which has other important fixes).

#6 Updated by Go MAEDA about 1 month ago

Marius, thank you for submitting updated patches. Those are works fine for me.

#7 Updated by Go MAEDA 18 days ago

  • Related to Feature #13558: Add version filter in spent time report added

Also available in: Atom PDF