Patch #27139

Fix for project link background in calendar tooltips

Added by Bernhard Rohloff about 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Calendar
Target version:3.3.6

Description

The project link in the calendar tooltip shows the same background image (starting, ending) as the related issue number.
The patch adds a :first-child selector in the default application.css file.

Before patch:

After patch:

calendar_tooltip_issue.png (9.31 KB) Bernhard Rohloff, 2017-10-08 11:15

calendar_tooltip_fixed.png (9.62 KB) Bernhard Rohloff, 2017-10-08 11:15

calendar_tooltip_fix_project_background.diff Magnifier (1.24 KB) Bernhard Rohloff, 2017-10-08 11:20

calendar_tooltip_fix_suggested_by_marius.diff Magnifier - The new fix with the 'table.cal .starting a.issue' selector (1.28 KB) Bernhard Rohloff, 2017-11-27 06:43

Associated revisions

Revision 17039
Added by Go MAEDA about 1 year ago

Fix: Unnecessary arrow icon beside a project link in calendar tooltips (#27139).

Patch by Bernhard Rohloff.

Revision 17040
Added by Go MAEDA about 1 year ago

Merged r17039 to 3.4-stable (#27139).

Revision 17041
Added by Go MAEDA about 1 year ago

Merged r17039 to 3.3-stable (#27139).

History

#1 Updated by Mischa The Evil about 1 year ago

  • Target version set to Unplanned

#2 Updated by Go MAEDA about 1 year ago

  • Target version changed from Unplanned to 3.3.6

I think there is no problem to include this small UI fix in the next minor release. Setting target version to 3.3.6.

#3 Updated by Marius BALTEANU about 1 year ago

I think that it is more safe to target directly the issue using table.cal .starting a.issue instead of the :first-child.

#4 Updated by Bernhard Rohloff about 1 year ago

Yes, I agree. Marius' approach is much cleaner. Thank you!
I've made another patch with the changes suggested by him.

#5 Updated by Go MAEDA about 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed in the trunk and merged to stable branches.
Thank you for fixing this issue and thank Marius for reviewing the patch.

Also available in: Atom PDF