Patch #28169

Enable and add underline button to the toolbar for Markdown formatting

Added by Marius BALTEANU over 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Text formatting
Target version:4.0.0

Description

Textile formatting has the "Underline" option for text formatting and I find it useful to have it also for Markdown.

The attached patch implements this.

As a side note, until this patch, the '_' was an alternative to '*' (italic), but I don't think that many users were aware by this alternative because Redmine uses the '*' in help docs and in the generated markup by Italic button.

0001-enable-and-add-underline-button-for-markdown.patch Magnifier (100 KB) Marius BALTEANU, 2018-02-17 16:36


Related issues

Related to Redmine - Defect #31929: MarkdownFormatterTest#test_should_support_underlined_text... Closed

Associated revisions

Revision 17385
Added by Jean-Philippe Lang about 1 year ago

Enable and add underline button to the toolbar for Markdown formatting (#28169).

Patch by Marius BALTEANU.

History

#1 Updated by Mischa The Evil over 1 year ago

  • Target version set to Unplanned backlogs

LGTM.

#2 Updated by Marius BALTEANU over 1 year ago

  • File deleted (0001-enable-and-adds-underline-button-for-markdown-format.patch)

#3 Updated by Marius BALTEANU over 1 year ago

Updated the patch to apply cleanly after r17198. It'll be nice to deliver this feature along with #28119.

#4 Updated by Mischa The Evil over 1 year ago

  • Target version changed from Unplanned backlogs to 4.0.0

Marius BALTEANU wrote:

It'll be nice to deliver this feature along with #28119.

I agree. I don't see any reason why it shouldn't be possible.

#5 Updated by Jean-Philippe Lang about 1 year ago

  • Status changed from New to Closed

Patch committed, thanks!

#6 Updated by Go MAEDA about 1 year ago

  • Assignee set to Jean-Philippe Lang

#7 Updated by Marius BALTEANU 5 days ago

  • Related to Defect #31929: MarkdownFormatterTest#test_should_support_underlined_text is declared as private added

Also available in: Atom PDF