Defect #28204: Too large avatar breaks gantt when assignee is a group - Redmine

Actions

Copy link

Defect #28204

closed

Too large avatar breaks gantt when assignee is a group

Added by Go MAEDA about 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Gantt

Target version:

3.3.7

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

3.3.6

Description

A 128px wide avatar icon breaks gantt view when the assignee of an issue is a group and "Use Gravatar user icons" setting is enabled.

The problem is introduced in Redmine 3.3.6 and 3.4.4 by #26699. The cause is that the HTML doesn't include "width" and "height" option because image_tag in Rails 4 doesn't accept an integer value for ":size" option (Rails 5 accepts both integer and string value, so the current trunk is not affected).

Redmine 3.4 (img element doesn't have "width" and "height" attributes):

<img alt="" title="Assignee: A Team" class="gravatar icon-gravatar" default="default" src="/images/anonymous.png?1518850381">

The current trunk (img element has "width" and "height" attributes):

<img alt="" title="Assignee: A Team" class="gravatar icon-gravatar" default="default" src="/images/anonymous.png?1517405352" width="13" height="13">

Files

Download all files

too-large-icon@2x.png (36.1 KB) too-large-icon@2x.png		Go MAEDA, 2018-02-17 10:33
test_size_option_for_avatar_should_accept_integer_value.diff (529 Bytes) test_size_option_for_avatar_should_accept_integer_value.diff	test to catch this issue	Go MAEDA, 2018-02-18 00:35
size_option_for_avatar_should_accept_integer_value.diff (537 Bytes) size_option_for_avatar_should_accept_integer_value.diff	fix for this issue (no need to apply this fix to the trunk)	Go MAEDA, 2018-02-18 00:36