Defect #26699: Anonymous user should have their icon - Redmine

Actions

Copy link

Defect #26699

closed

Anonymous user should have their icon

Added by Go MAEDA over 6 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

3.3.6

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

ApplicationHelper#avatar method returns blank string instead of img tag for the anonymous user. The behavior causes disordered layout in IssuesController#show page.

This patch adds an icon for the anonymous user and fixes the broken layout.

Before:
The author of the issue is the anonymous user. But in the upper left corner of the page, the assignee's icon is displayed as if it is the author's icon because the anonymous user does not have their avatar icon.

No icon is displayed in the journal which was made by the anonymous user.

After:
New anonymous icon is displayed.

Files

Download all files

before1@2x.png (12.5 KB) before1@2x.png		Go MAEDA, 2017-08-15 16:32
before2@2x.png (7.66 KB) before2@2x.png		Go MAEDA, 2017-08-15 16:32
after1@2x.png (13.3 KB) after1@2x.png		Go MAEDA, 2017-08-15 16:32
after2@2x.png (8.56 KB) after2@2x.png		Go MAEDA, 2017-08-15 16:32
anonymous.ai (371 KB) anonymous.ai	Vector data of the icon (Adobe Illustrator CC 2017)	Go MAEDA, 2017-08-15 17:15
0001-Add-avatar-for-anonymous-user.patch (3.91 KB) 0001-Add-avatar-for-anonymous-user.patch	patch	Go MAEDA, 2017-08-15 17:52

Related issues

Actions

Copy link

Updated by Go MAEDA over 6 years ago

Related to Patch #25775: Show assignee's icon in addition to author's icon added

Actions

Copy link

Updated by Go MAEDA over 6 years ago

File anonymous.ai anonymous.ai added

Actions

Copy link

Updated by Go MAEDA over 6 years ago

File 0001-Add-avatar-for-anonymous-user.patch 0001-Add-avatar-for-anonymous-user.patch added

Updated tests.

Actions

Copy link

Updated by Go MAEDA over 6 years ago

File deleted (~~0001-Add-avatar-for-anonymous-user.patch~~)

Actions

Copy link

Updated by Go MAEDA over 6 years ago

Target version set to 3.4.3

I think it is problematic that an assignee's icon looks like an author's icon in Redmine 3.4 when the issue's author is an anonymous user.

I suggest including this fix in 3.4.3.

Actions

Copy link

Updated by Jean-Philippe Lang over 6 years ago

Target version changed from 3.4.3 to 3.4.4

I think it would be better to use the default gravatar icon instead of using our own.
What do you think?

Actions

Copy link

Updated by Go MAEDA over 6 years ago

Jean-Philippe Lang wrote:

I think it would be better to use the default gravatar icon instead of using our own.
What do you think?

I prefer to have a special icon for anonymous user. We cannot distinguish a regular user with no Gravatar icon and anonymous user if default Gravatar icon is used for anonymous users.

Actions

Copy link

Updated by Mischa The Evil over 6 years ago

Go MAEDA wrote:

[...]

I prefer to have a special icon for anonymous user. We cannot distinguish a regular user with no Gravatar icon and anonymous user if default Gravatar icon is used for anonymous users.

I agree with Go MEADA on this. We should be able to distinguish between regular users without Gravatar and anonymous user(s).

Actions

Copy link