Patch #25775

Show assignee's icon in addition to author's icon

Added by Go MAEDA about 1 month ago. Updated 18 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.4.0

Description

In current versions of Redmine, author's icon is displayed in the upper left corner of issues if "Use Gravatar user icons" setting is enabled.

I think it would be very useful if we can see assignee's icon in addition to author's icon because who is the person in charge is important information to manage projects.

Currently we can see very small (14px) assignee's icon in "Assignee" field but it is not noticeable. If attached patch (0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch) is applied, assignee's icon will be much noticeable and we can easily know current assignee.

screenshot

assignee-icon-with-author-icon@2x.png - screenshot (90.3 KB) Go MAEDA, 2017-05-06 07:58

0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch Magnifier - patch (1.52 KB) Go MAEDA, 2017-05-06 07:59

25775-test.patch Magnifier - Patch for test (issue controller and UI) (1.01 KB) Akiko Takano, 2017-05-08 01:17

0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch Magnifier - patch (compatible with redmine_local_avatars plugin) (1.56 KB) Go MAEDA, 2017-05-08 09:23

25775-ui-test.patch Magnifier (1.46 KB) Akiko Takano, 2017-05-08 13:52


Related issues

Related to Redmine - Feature #19648: Ability to show the Issue Assigne avatar instead of Autho... New

Associated revisions

Revision 16655
Added by Jean-Philippe Lang 18 days ago

Show assignee's icon in addition to author's icon (#25775).

Patch by Go MAEDA.

Revision 16656
Added by Jean-Philippe Lang 18 days ago

Adds tests for #25775.

Revision 16657
Added by Jean-Philippe Lang 18 days ago

Removes duplicate avatar of assignee (#25775).

Revision 16658
Added by Jean-Philippe Lang 18 days ago

Adds some margin to issue gravatar (#25775).

History

#1 Updated by Go MAEDA about 1 month ago

  • Related to Feature #19648: Ability to show the Issue Assigne avatar instead of Author avatar added

#2 Updated by Akiko Takano about 1 month ago

i’ve just tried above patch and it works fine. (Including responsive layout).
Since I made simple test for this patch, I hope this would be any help.

BTW, I’m using not Gravatar but local avatar plugin to display avatars, https://github.com/ncoders/redmine_local_avatars.
It seems this plugin does not append / override class setting, such as "gravatar-child" to second avatar icon (for assignee), so that icon for assignee does not appear at the expected position. (Not Lower right, but Upper right)

Of course, this is plugin’s reason, but if you could, please apply the same style to div.gravatar-with-child > img:nth-child(2).

hg diff public/stylesheets/application.css
diff -r f5c7cc60ead2 public/stylesheets/application.css
--- a/public/stylesheets/application.css    Tue Apr 25 17:44:08 2017 +0000
+++ b/public/stylesheets/application.css    Mon May 08 08:14:29 2017 +0900
@@ -1313,6 +1313,18 @@
   margin: 0 6px 0 0;
 }

+div.gravatar-with-child {
+  position: relative;
+}
+
+img.gravatar-child, div.gravatar-with-child > img:nth-child(2) {
+  position: absolute;
+  top: 30px;
+  left: 30px;
+  border-radius: 20%;
+  border: 2px solid rgba(255, 255, 255, 0.9);
+}

Sorry, I failed to attach the patch for UI test. I'll attache it later.

#3 Updated by Go MAEDA about 1 month ago

Akiko-san, thank you for adding tests and pointing out redmine_local_avatars plugin.
I have updated patch. Now it is compatible with the plugin.

#4 Updated by Akiko Takano about 1 month ago

Maeda-san, thank you for picking up my request.
As I wrote above, attach an additional ui test, I’m glad if this would be help for reviewing or release planning.
(I tested with using Chromedriver and PhantomJS)

Sincerely,

Go MAEDA wrote:

Akiko-san, thank you for adding tests and pointing out redmine_local_avatars plugin.
I have updated patch. Now it is compatible with the plugin.

#5 Updated by Go MAEDA about 1 month ago

  • Target version set to 3.4.0

I am sure that this feature is useful for most users. And the feature got many likes on Twitter: https://twitter.com/g_maeda/status/861485901389504512

Let's merge this feature into trunk along with tests by Akiko Takano. Setting target version to 3.4.0.

#6 Updated by Marius BALTEANU about 1 month ago

Just a note regarding the tests, IMHO, there are no reasons to have UI tests with PhantomJS (which are slower) for this feature. The same assertions can be made as well in a functional test.

#7 Updated by Akiko Takano about 1 month ago

Marius, thanks for your comment.

The same assertions can be made as well in a functional test.

Sorry, since I do not know what kind of test is required, I uploaded both types of test.
Looking forward to the next release.

#8 Updated by Marius BALTEANU about 1 month ago

Akiko Takano wrote:

Sorry, since I do not know what kind of test is required, I uploaded both types of test.
Looking forward to the next release.

Ah, sorry, I didn't see the functional tests from 25775-test.patch. They look good to me.

#9 Updated by Jan from Planio www.plan.io about 1 month ago

I think this feature would be a great UI improvement!

#10 Updated by Vasili Korol about 1 month ago

It would be very nice to have this feature. Sometimes users mistake the author's avatar for the assignee.

#11 Updated by Jean-Philippe Lang 18 days ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch is committed with fixed functional tests. UI tests are not appropriate for this indeed.
I've also removed the duplicate assignee avatar to clean up the display.
Thanks.

Also available in: Atom PDF