Project

General

Profile

Actions

Defect #28931

closed

Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project

Added by Pavel Rosický almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

this test probably never acually worked

Issue.order('id DESC').limit(issues.size)

issues.size was zero in rails < 5.2, it tests nothing

after this change it fails
https://github.com/rails/rails/commit/06f45435da941d713afefd3140421d1ced7abbdc

so I removed it


Files

issues_controller_test.rb.patch (535 Bytes) issues_controller_test.rb.patch Pavel Rosický, 2018-06-01 21:53

Related issues

Related to Redmine - Feature #23630: Migrate to Rails 5.2ClosedJean-Philippe Lang

Actions
Actions

Also available in: Atom PDF