Patch #28934
Support migration context for plugins
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Rails support | |||
Target version: | 4.0.0 |
Related issues
Associated revisions
Support migration context for plugins (#28934).
Removed message to stdout (#28934).
History
#1
Updated by Pavel Rosický 9 months ago
- File plugin.rb.patch
added
#2
Updated by Go MAEDA 9 months ago
- Related to Patch #28933: Migrate to Rails 5.2 added
#3
Updated by Tatsuya Saito 8 months ago
- File add_unittest.patch
added
I attach a patch to add simple unit test.
I hope to fix this issue :)
#5
Updated by Toru Takahashi 8 months ago
+1 this patch is needed to migrate a plugin by redmine:plugins:migrate on rails 5.2.
#6
Updated by Tatsuya Saito 8 months ago
- File use_migration_context_with_test.patch
added
I think release version like 3.4.x is NOT going to support Rails 5.2, keep 4.x.
So I created a patch which is removed condition of Rails version check for older than trunk.
I attatch it, and it includes add_unittest.patch.
#7
Updated by Pavel Rosický 8 months ago
@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.
Btw: my patch also loads schema_migrations only once for all plugins, so there's also a performance impact if you have more plugins installed.
Unfortunatelly I have to duplicate MigrationContext because it calls back the original Migrator class from Rails not the patched one by Redmine. Maybe someone can figure out a better solution.
#8
Updated by Tatsuya Saito 7 months ago
- File use_migration_context_with_test2.patch
added
Pavel Rosický wrote:
@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.
Thanks comment and sorry broke your patch.
I fix and attach it.
#9
Updated by Pavel Rosický 7 months ago
It's ok. Thanks for testing
#10
Updated by Jean-Philippe Lang 5 months ago
- Subject changed from [Rails 5.2] support migration context to Support migration context for plugins
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks.
#11
Updated by Go MAEDA 3 months ago
- Duplicated by Defect #29291: NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:Class added