Patch #28934
closed
Support migration context for plugins
Added by Pavel Rosický almost 6 years ago. Updated over 5 years ago.
0%
Files
| plugin.rb.patch (3.27 KB) plugin.rb.patch | Pavel Rosický, 2018-06-02 00:38 | ||
| add_unittest.patch (534 Bytes) add_unittest.patch | Tatsuya Saito, 2018-06-27 00:41 | ||
| use_migration_context_with_test.patch (1.06 KB) use_migration_context_with_test.patch | Tatsuya Saito, 2018-07-05 16:48 | ||
| use_migration_context_with_test2.patch (3.54 KB) use_migration_context_with_test2.patch | Tatsuya Saito, 2018-07-07 04:23 |
Related issues
Updated by Pavel Rosický almost 6 years ago
- File plugin.rb.patch plugin.rb.patch added
Updated by Go MAEDA almost 6 years ago
- Related to Patch #28933: Migrate to Rails 5.2 added
Updated by Tatsuya Saito almost 6 years ago
- File add_unittest.patch add_unittest.patch added
I attach a patch to add simple unit test.
I hope to fix this issue :)
Updated by Go MAEDA almost 6 years ago
- Category changed from Performance to Rails support
- Target version set to 4.0.0
Updated by Toru Takahashi almost 6 years ago
+1 this patch is needed to migrate a plugin by redmine:plugins:migrate on rails 5.2.
Updated by Tatsuya Saito almost 6 years ago
I think release version like 3.4.x is NOT going to support Rails 5.2, keep 4.x.
So I created a patch which is removed condition of Rails version check for older than trunk.
I attatch it, and it includes add_unittest.patch.
Updated by Pavel Rosický almost 6 years ago
@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.
Btw: my patch also loads schema_migrations only once for all plugins, so there's also a performance impact if you have more plugins installed.
Unfortunatelly I have to duplicate MigrationContext because it calls back the original Migrator class from Rails not the patched one by Redmine. Maybe someone can figure out a better solution.
Updated by Tatsuya Saito almost 6 years ago
Pavel Rosický wrote:
@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.
Thanks comment and sorry broke your patch.
I fix and attach it.
Updated by Jean-Philippe Lang over 5 years ago
- Subject changed from [Rails 5.2] support migration context to Support migration context for plugins
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks.
Updated by Go MAEDA over 5 years ago
- Has duplicate Defect #29291: NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:Class added