Project

General

Profile

Actions

Patch #30445

closed

Remove unnecessary bgl and bgr wrappers from the footer

Added by Anonymous almost 6 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

There is a footer container, which has 2 more containers inside named bgl and bgr, considering that footer has nothing in it, but a short line of text, and I don't think we will ever need anything else from the footer, than just displaying this line, I think they both should be killed and text that's contained by it to be instead wrapped directly by a #footer div.


Files

bgl-bgr-removal.patch (495 Bytes) bgl-bgr-removal.patch Anonymous, 2019-01-16 18:20
redmine.org#footer-20190915.png (107 KB) redmine.org#footer-20190915.png Mischa The Evil, 2019-09-15 04:10

Related issues

Related to Redmine - Patch #30231: Operation: "Unwraping The Mine" or conerns about how elements are wrappedClosed

Actions
Related to Redmine - Feature #871: Commit new CSS styles!ClosedJean-Philippe Lang2008-03-15

Actions
Actions #1

Updated by Marius BĂLTEANU almost 6 years ago

  • Related to Patch #30231: Operation: "Unwraping The Mine" or conerns about how elements are wrapped added
Actions #2

Updated by Go MAEDA almost 6 years ago

Actions #3

Updated by Go MAEDA almost 6 years ago

wrapper2, .bgl, and .bgr were added in response to the request #871. Those classes are no longer used in both the default theme and redmine.org's theme.

Actions #4

Updated by Marius BĂLTEANU almost 6 years ago

LGTM.

Actions #5

Updated by Marius BĂLTEANU almost 6 years ago

  • Target version set to Candidate for next major release
Actions #6

Updated by Go MAEDA almost 6 years ago

  • Target version changed from Candidate for next major release to 4.1.0

The classes are no longer used even in redmine.org. Setting the target version to 4.1.0.

Actions #7

Updated by Go MAEDA almost 6 years ago

  • Category changed from UI to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you for your contribution.

Actions #8

Updated by Mischa The Evil about 5 years ago

I think that this change will, without further action, become problematic for the redmine.org instance:

<screenshot removed>

Actions #9

Updated by Mischa The Evil about 5 years ago

Please ignore my previous comment. I misinterpreted some things.

Actions

Also available in: Atom PDF