Patch #30445

Remove unnecessary bgl and bgr wrappers from the footer

Added by Anonymous 7 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.1.0

Description

There is a footer container, which has 2 more containers inside named bgl and bgr, considering that footer has nothing in it, but a short line of text, and I don't think we will ever need anything else from the footer, than just displaying this line, I think they both should be killed and text that's contained by it to be instead wrapped directly by a #footer div.

bgl-bgr-removal.patch Magnifier (495 Bytes) Anonymous, 2019-01-16 18:20


Related issues

Related to Redmine - Patch #30231: Operation: "Unwraping The Mine" or conerns about how elem... Closed
Related to Redmine - Feature #871: Commit new CSS styles! Closed 2008-03-15

Associated revisions

Revision 17839
Added by Go MAEDA 7 months ago

Remove unnecessary bgl and bgr wrappers from the footer (#30445).

Patch by Max Johansson.

History

#1 Updated by Marius BALTEANU 7 months ago

  • Related to Patch #30231: Operation: "Unwraping The Mine" or conerns about how elements are wrapped added

#2 Updated by Go MAEDA 7 months ago

#3 Updated by Go MAEDA 7 months ago

wrapper2, .bgl, and .bgr were added in response to the request #871. Those classes are no longer used in both the default theme and redmine.org's theme.

#4 Updated by Marius BALTEANU 7 months ago

LGTM.

#5 Updated by Marius BALTEANU 7 months ago

  • Target version set to Candidate for next major release

#6 Updated by Go MAEDA 7 months ago

  • Target version changed from Candidate for next major release to 4.1.0

The classes are no longer used even in redmine.org. Setting the target version to 4.1.0.

#7 Updated by Go MAEDA 7 months ago

  • Category changed from UI to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you for your contribution.

Also available in: Atom PDF