Defect #30923

Project search should select subprojects scope when the project has subprojects

Added by Yuuki NARA 7 months ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Search engine
Target version:3.4.10
Resolution:Fixed Affected version:3.4.6

Description

In the following tickets,
the project search has been changed by Redmine 3.4.0 to include subprojects by default,

Search in project and its subprojects by default
http://www.redmine.org/issues/9909

But it is not working as expected.
Selected the project itself.

I confirmed it in Redmine 3.4.6.

scope-test-1@2x.png (48 KB) Go MAEDA, 2019-02-27 04:44

scope-test-2@2x.png (46.2 KB) Go MAEDA, 2019-02-27 04:45

0001-Project-search-should-select-subprojects-scope-when-.patch Magnifier (7.02 KB) Marius BALTEANU, 2019-03-24 09:54


Related issues

Related to Redmine - Feature #9909: Search in project and its subprojects by default Closed

Associated revisions

Revision 18005
Added by Go MAEDA 6 months ago

Project search should select subprojects scope when the project has subprojects (#30923).

Patch by Marius BALTEANU.

Revision 18006
Added by Go MAEDA 6 months ago

Merged r18005 from trunk to 4.0-stable (#30923).

Revision 18007
Added by Go MAEDA 6 months ago

Merged r18005 from trunk to 3.4-stable (#30923).

History

#1 Updated by Go MAEDA 7 months ago

  • Related to Feature #9909: Search in project and its subprojects by default added

#2 Updated by Go MAEDA 7 months ago

I tested the behavior on the current trunk. NARA-san, are you talking about the second behavior?

  1. Redmine searches the current project and its subprojects when you enter search keywords to the box on the upper-right corner. It seems working as expected.
  2. If you click the label "Search" on the left side of the box, the default scope is the current project only.

#3 Updated by Yuuki NARA 7 months ago

Maeda-San, Thank you for pointing out.

I was doing the operation of test-2.

Even in my own environment, test-1 has Subproject, and in test-2 it has only Project itself.

In issue9909, it seems that this difference is not mentioned at all.

There are two operation methods test1 and test2.

Which is running

Was the fix that JPL committed effective only when you performed test-1 operation?

#4 Updated by Go MAEDA 7 months ago

  • Assignee deleted (Yuuki NARA)

Yuuki NARA wrote:

I was doing the operation of test-2.

Even in my own environment, test-1 has Subproject, and in test-2 it has only Project itself.

Thank you for clarifying. I think the scope drop-down which is shown by the second operation also should include subprojects, as you insist.

#5 Updated by Yuuki NARA 7 months ago

+1

The operation of the search operation should be consistent.

#6 Updated by Marius BALTEANU 6 months ago

  • Assignee set to Marius BALTEANU

#7 Updated by Marius BALTEANU 6 months ago

Attach the patch with the fix and tests for this issue and also for #9909.

I think we can deliver this small change in 3.4.10.

#8 Updated by Go MAEDA 6 months ago

  • Subject changed from Project search does not select subproject by default to Project search should select subprojects scope when the project has subprojects
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you all for reporting and fixing the issue.

#9 Updated by Go MAEDA 6 months ago

  • Status changed from Confirmed to Resolved

#10 Updated by Go MAEDA 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF