Feature #4774

Change the hyperlink for file attachment to view and download

Added by Wirianto Djunaidi almost 8 years ago. Updated over 5 years ago.

Status:ClosedStart date:2010-02-09
Priority:LowDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:1.4.0
Resolution:Fixed

Description

Current hyperlink for file attachment can cause confusion to some user. They assume the link point to the file and use browser's "Save Link As" on it and not getting what user is expecting.

It will be better for each of the file attachment to display 2 links right away called "View" and "Download" that goes to the appropriate controller.


Related issues

Duplicated by Redmine - Feature #8176: TXT attachment download Closed 2011-04-18

Associated revisions

Revision 8645
Added by Jean-Philippe Lang almost 6 years ago

Change attachment link to download and add a view link for text attachments (#4774).

Revision 9326
Added by Toshi MARUYAMA over 5 years ago

add a view link to note attachment file (#4774)

Revision 9333
Added by Jean-Philippe Lang over 5 years ago

Do not display the magnifier for added files in email notifications (#4774).

History

#1 Updated by Ewan Makepeace almost 8 years ago

I think this has different behaviour for text files and other types (which makes it even worse!) - text files link to a formatted view of the file contents (HTML) while other types link to the file itself?
Inconsistency leads to mistakes...

#2 Updated by Etienne Massip over 6 years ago

  • Target version set to Candidate for next major release

Agreed, I'm doing the same mistake each time too.

#3 Updated by Cassiano Monteiro over 6 years ago

Please refer to feature #8176 for sample TXT files.

#4 Updated by Jean-Philippe Lang almost 6 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next major release to 1.4.0
  • Resolution set to Fixed

Attachment links changed so that they download the file. A link to view the file is added for text files.

#5 Updated by Etienne Massip over 5 years ago

  • Status changed from Closed to Reopened

Reopened to get sure that r9326 behaves finely with email notifications?

#6 Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from Reopened to Closed

Etienne Massip wrote:

Reopened to get sure that r9326 behaves finely with email notifications?

It doesn't since image_tag use path only. It's removed in email notifications in r9333.

Also available in: Atom PDF