Defect #6627

missing "add new file" in Files section

Added by Mike Lu over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:2010-10-11
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:-
Target version:-
Affected version:devel Resolution:Fixed

Description

after upgraded to 1.0.2, i found that i could no longer upload files in Files section since the link to upload new file is missing; however, uploading via attachment is still working.

Related issues

duplicates Defect #6513: "Move" and "Copy" are not displayed when deployed in subd... Closed 2010-09-28

Associated revisions

Revision 4268
Added by Jean-Philippe Lang over 1 year ago

Fixed: "Add file" link broken by recent refactoring (#6627).

History

#1 Updated by Holger Just over 1 year ago

Make sure the user you are testing with has the "Manage Files" permission in the respective project.

Apart from that, I can not reproduce this issue.

#2 Updated by Mike Lu over 1 year ago

yes, user permission i'm testing could "Manage Files". another evidence is that "Delete" button has shown up. i had modified the source so that files could be uploaded to configured folder, i'll try to remove the modification to see if the problem is caused by that.

#3 Updated by Mischa The Evil over 1 year ago

I'm not able to reproduce this behaviour on a clean checkout of 1.0-stable.

The issue is indeed most likely caused by some core-modifications...

#4 Updated by Xagyg Wulf over 1 year ago

My upgrade reset role permissions. Re-checking "manage files" etc. fixed the problem. Just pointing this out here in case you weren't aware of that.

#5 Updated by Holger Just over 1 year ago

  • Status changed from New to Closed
  • Resolution set to Cant reproduce

As this was resolved by removing core changes, I'm closing this issue.

#6 Updated by Mike Lu over 1 year ago

  • Status changed from Closed to Reopened

sorry that i didn't clearly list my environment, the version of my redmine should be trunk version on windows with apache2 and is served in a sub-URI "/redmine". and the user i tested with has checked to have "manage files" permission.

i have found the cause that as long as redmine is started in a sub-URI, the link of "New file" would be missing, with my modified version or with a clean checkout of trunk (r4249)

i have tried both thin and mongrel server that all showed up the same result:

  1. added Redmine::Utils::relative_url_root = "/redmine" to the bottom of environment.rb, after the last end statement
  2. started the server with command thin start -e production or ruby script/server start -e production
  3. link was missing in Files section
  4. applied the test on clean checkout and the link was also missing
but if i
  1. reverted the modification in environment.rb (no Redmine::Utils::relative_url_root = "/redmine" at the end)
  2. start the server with command thin start -e production or ruby script/server start -e production
  3. link showed up
  4. applied the test on clean checkout and the link also showed up

so i don't think to problem is caused by my modification or my environment

#7 Updated by Felix Schäfer over 1 year ago

  • Affected version changed from 1.0.2 to devel

Ah, I think that's one of Eric's refactors gone south. I think I had a solution up for that, though it seems it hasn't been added to trunk yet. I'll try to find it and poke him long enough that he commits it.

#8 Updated by Felix Schäfer over 1 year ago

See if #6513 solves this for you, I think it's the same issue.

#9 Updated by Mike Lu over 1 year ago

like what Eric has done in r4258, with modification in r4257, revision r3616 should also be partially reverted to solve this problem, and some other revisions, too, to solve #6650

#10 Updated by Mike Lu over 1 year ago

problem solved after backout the whole r3616

#11 Updated by Jean-Philippe Lang over 1 year ago

  • Status changed from Reopened to Closed
  • Resolution changed from Cant reproduce to Fixed

Fixed in r4268.

Also available in: Atom PDF