Project

General

Profile

Feature #32030 » 0001-Code-cleanup-RuboCop-Fix-Performance-RedundantMerge.patch

Go MAEDA, 2019-12-01 05:25

View differences:

.rubocop_todo.yml
Exclude:
- 'app/controllers/issues_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/avatars_helper.rb'
- 'app/helpers/custom_fields_helper.rb'
- 'app/helpers/workflows_helper.rb'
- 'app/models/auth_source_ldap.rb'
app/helpers/avatars_helper.rb
def assignee_avatar(user, options={})
return '' unless user
options.merge!(:title => l(:field_assigned_to) + ": " + user.name)
options[:title] = l(:field_assigned_to) + ': ' + user.name
avatar(user, options).to_s.html_safe
end
def author_avatar(user, options={})
return '' unless user
options.merge!(:title => l(:field_author) + ": " + user.name)
options[:title] = l(:field_author) + ': ' + user.name
avatar(user, options).to_s.html_safe
end
......
# +user+ can be a User or a string that will be scanned for an email address (eg. 'joe <joe@foo.bar>')
def avatar(user, options = { })
if Setting.gravatar_enabled?
options.merge!(:default => Setting.gravatar_default)
options[:default] = Setting.gravatar_default
options[:class] = GravatarHelper::DEFAULT_OPTIONS[:class] + " " + options[:class] if options[:class]
email = nil
if user.respond_to?(:mail)
(5-5/6)