Defect #34856 » 0001-Allow-adding-time-entry-on-an-issue-that-became-priv.patch
| app/models/time_entry.rb | ||
|---|---|---|
|
self.project_id = issue.project_id
|
||
|
end
|
||
|
@invalid_issue_id = nil
|
||
|
elsif user.allowed_to?(:log_time, issue.project) && issue.assigned_to_id_changed? && issue.previous_assignee == User.current
|
||
|
current_assignee = issue.assigned_to
|
||
|
issue.assigned_to = issue.previous_assignee
|
||
|
unless issue.visible?(user)
|
||
|
@invalid_issue_id = issue_id
|
||
|
end
|
||
|
issue.assigned_to = current_assignee
|
||
|
else
|
||
|
@invalid_issue_id = issue_id
|
||
|
end
|
||
| test/functional/issues_controller_test.rb | ||
|---|---|---|
|
assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
|
||
|
end
|
||
|
def test_put_with_spent_time_when_assigned_to_of_private_issue_is_update_at_the_same_time
|
||
|
@request.session[:user_id] = 3
|
||
|
Role.find(2).update! :issues_visibility => 'own'
|
||
|
private_issue = Issue.find(3)
|
||
|
assert_difference('TimeEntry.count', 1) do
|
||
|
put(
|
||
|
:update,
|
||
|
params: {
|
||
|
id: private_issue.id,
|
||
|
issue: { assigned_to_id: nil },
|
||
|
time_entry: {
|
||
|
comments: "add spent time", activity_id: TimeEntryActivity.first.id, hours: 1
|
||
|
}
|
||
|
}
|
||
|
)
|
||
|
end
|
||
|
assert_select '#errorExplanation', {text: /Log time is invalid/, count: 0}
|
||
|
assert_select '#errorExplanation', {text: /Issue is invalid/, count: 0}
|
||
|
assert_redirected_to action: 'show', id: private_issue.id
|
||
|
assert_not private_issue.reload.visible?
|
||
|
end
|
||
|
def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
|
||
|
issue = Issue.find(2)
|
||
|
@request.session[:user_id] = 2
|
||
- « Previous
- 1
- 2
- 3
- Next »