Project

General

Profile

Feature #36376 » 0001-Add-confirm-to-delete-link.patch

Mizuki ISHIKAWA, 2022-01-04 03:01

View differences:

app/views/projects/settings/_members.html.erb
:class => 'icon icon-edit' %>
<%= delete_link membership_path(member),
:remote => true,
:data => (!User.current.admin? && member.include?(User.current) ? {:confirm => l(:text_own_membership_delete_confirmation)} : {}) if member.deletable? %>
:data => {:confirm => (!User.current.admin? && member.include?(User.current) ? l(:text_own_membership_delete_confirmation) : l(:text_are_you_sure))} if member.deletable? %>
</td>
<%= call_hook(:view_projects_settings_members_table_row, { :project => @project, :member => member}) %>
</tr>
test/functional/projects_controller_test.rb
assert_select "tr#member-#{member.id}"
end
def test_settings_should_show_delete_link_with_confirmation_message
@request.session[:user_id] = 2
get(
:settings,
:params => {
:id => 'ecookbook',
:tab => 'members'
}
)
assert_response :success
# A link for the current user to remove own from the membership
assert_select "tr#member-1 a.icon-del[data-confirm='#{l(:text_own_membership_delete_confirmation)}']"
# A link to remove other user from the membership
assert_select "tr#member-2 a.icon-del[data-confirm='#{l(:text_are_you_sure)}']"
end
def test_settings_should_show_tabs_depending_on_permission
@request.session[:user_id] = 3
project = Project.find(1)
(1-1/4)