Defect #43964 ยป Fix-scm_change_icon-ignoring-passed-options.patch
| app/helpers/icons_helper.rb | ||
|---|---|---|
| 79 | 79 |
sprite_icon(icon_name, **) |
| 80 | 80 |
end |
| 81 | 81 | |
| 82 |
def scm_change_icon(action, name, **options)
|
|
| 82 |
def scm_change_icon(action, name, **) |
|
| 83 | 83 |
icon_name = case action |
| 84 | 84 |
when 'A' |
| 85 | 85 |
"add" |
| ... | ... | |
| 88 | 88 |
else |
| 89 | 89 |
"circle-dot-filled" |
| 90 | 90 |
end |
| 91 |
sprite_icon(icon_name, name, size: 14) |
|
| 91 |
sprite_icon(icon_name, name, size: 14, **)
|
|
| 92 | 92 |
end |
| 93 | 93 | |
| 94 | 94 |
def notice_icon(type, **) |
| test/helpers/icons_helper_test.rb | ||
|---|---|---|
| 245 | 245 |
def test_icon_for_mime_type_should_return_generic_file_icon_for_unknown_mime_types |
| 246 | 246 |
assert_equal 'file', icon_for_mime_type('unknown-type')
|
| 247 | 247 |
end |
| 248 | ||
| 249 |
def test_scm_change_icon_should_set_default_size |
|
| 250 |
expected = %r{<svg class="s14 icon-svg" aria-hidden="true"><use href="/assets/icons-\w+.svg#icon--add"></use></svg><span class="icon-label hidden">Added</span>}
|
|
| 251 | ||
| 252 |
assert_match expected, scm_change_icon('A', 'Added', icon_only: true)
|
|
| 253 |
end |
|
| 248 | 254 |
end |