Project

General

Profile

Actions
Copy link

Defect #43964

closed

`IconsHelper#scm_change_icon` ignores passed options

Added by Go MAEDA about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
SCM
Target version:
6.1.3
Resolution:
Fixed
Affected version:

Description

IconsHelper#scm_change_icon accepts keyword options, but when it calls sprite_icon, it does not pass them through.

As a result, options such as icon_only: true are ignored. This makes scm_change_icon behave inconsistently with its method signature.

The attached patch fixes this by forwarding the received options to the internal sprite_icon call while keeping the default size at 14.

Files

Fix-scm_change_icon-ignoring-passed-options.patch (1.36 KB) Fix-scm_change_icon-ignoring-passed-options.patch Go MAEDA, 2026-04-17 04:37
Actions
Copy link
 #1

Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next minor release to 6.1.3

Setting the target version to 6.1.3.

Actions
Copy link
 #2

Updated by Go MAEDA about 1 month ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r24593.

Actions
Copy link
 #3

Updated by Go MAEDA about 1 month ago

  • Status changed from Resolved to Closed

Merged the fix into 6.1-stable branch in r24596.

Actions
Copy link

Also available in: Atom PDF