Project

General

Profile

Actions

Defect #43964

closed

`IconsHelper#scm_change_icon` ignores passed options

Added by Go MAEDA 21 days ago. Updated 16 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
SCM
Target version:
Resolution:
Fixed
Affected version:

Description

IconsHelper#scm_change_icon accepts keyword options, but when it calls sprite_icon, it does not pass them through.

As a result, options such as icon_only: true are ignored. This makes scm_change_icon behave inconsistently with its method signature.

The attached patch fixes this by forwarding the received options to the internal sprite_icon call while keeping the default size at 14.


Files

Actions

Also available in: Atom PDF