Project

General

Profile

Defect #44366 » 0001-Delete-workflow-rules-referring-to-an-issue-custom-f.patch

Go MAEDA, 2026-08-27 02:37

View differences:

app/models/issue_custom_field.rb
safe_attributes 'project_ids',
'tracker_ids'
before_destroy :delete_workflow_rules
def type_name
:label_issue_plural
end
# Deletes workflow rules that refer to this custom field
def delete_workflow_rules
WorkflowPermission.where(:field_name => id.to_s).delete_all
end
def visible_by?(project, user=User.current)
super || roles.intersect?(user.roles_for_project(project))
end
db/migrate/20260827002435_delete_orphaned_workflow_rules_of_custom_fields.rb
class DeleteOrphanedWorkflowRulesOfCustomFields < ActiveRecord::Migration[8.1]
def up
field_names = WorkflowPermission.where.not(field_name: nil).distinct.pluck(:field_name)
custom_field_ids = field_names.grep(/\A\d+\z/).map(&:to_i)
orphaned_ids = custom_field_ids - CustomField.where(id: custom_field_ids).pluck(:id)
if orphaned_ids.any?
WorkflowPermission.where(field_name: orphaned_ids.map(&:to_s)).delete_all
end
end
def down
# no-op
end
end
test/unit/issue_custom_field_test.rb
field.save!
assert_equal 0, field.roles.count
end
def test_destroy_should_delete_workflow_rules
field = IssueCustomField.create!(:name => 'Field', :field_format => 'string')
WorkflowPermission.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :field_name => field.id.to_s, :rule => 'required')
assert_equal 1, WorkflowPermission.where(:field_name => field.id.to_s).count
field.destroy
assert_equal 0, WorkflowPermission.where(:field_name => field.id.to_s).count
end
end
(2-2/2)