Project

General

Profile

Actions
Copy link

Defect #44366

closed

Deleting an issue custom field does not delete its workflow field permissions

Added by Liane Hampe 21 days ago. Updated 5 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Custom fields
Target version:
7.1.0
Resolution:
Fixed
Affected version:
6.0.9

Description

What did you expect?

Deleting a CustomField should also delete any workflow records that refer to that CustomField

What has happened instead?

The workflow table contains orphaned records that reference a non-existing CustomField.

What could be a possible solution?

IssueStatus has a before_destroy that cleans Workflow records with it's ID. Maybe something similar could work for CustomFields too.

How can we reproduce the problem?

  1. Create a IssueCustomField
  2. Define some WorkflowRules for it
  3. Delete the CustomField
  4. Check the DB, the WorkflowRule should still be there

In what environment are you?

Please copy and paste your environment information as displayed in Administration ยป Information or run bin/about in the root dir of your Redmine instance.

Environment:
Redmine version 6.0.9.stable
Ruby version 3.3.11-p205 (2026-03-26) [x86_64-linux]
Rails version 7.2.3.1
Environment development
Database adapter Mysql2

Files

Download all files
0001-Delete-workflow-rules-referring-to-an-issue-custom-f.patch (2.87 KB) 0001-Delete-workflow-rules-referring-to-an-issue-custom-f.patch Go MAEDA, 2026-08-23 08:13
0001-Delete-workflow-rules-referring-to-an-issue-custom-f.patch (3.04 KB) 0001-Delete-workflow-rules-referring-to-an-issue-custom-f.patch Go MAEDA, 2026-08-27 02:37
Actions
Copy link
 #1

Updated by Go MAEDA 20 days ago

Thank you for the report. I was able to reproduce the issue on the current trunk.

The attached patch adds before_destroy :delete_workflow_rules to IssueCustomField, as IssueStatus does. Deleting an issue custom field now also deletes the WorkflowRule records whose field_name refers to the custom field.

The patch also includes a database migration that removes workflow rules orphaned by previously deleted custom fields.

Actions
Copy link
 #2

Updated by Go MAEDA 19 days ago

  • Target version changed from Candidate for next major release to 7.1.0

Setting the target version to 7.1.0.

Actions
Copy link
 #3

Updated by Go MAEDA 16 days ago

Attached is an updated patch.

The deletion now uses the WorkflowPermission model instead of WorkflowRule, both in the before_destroy callback and in the migration. Since the records to be deleted are WorkflowPermission records, this expresses the intent more precisely and limits the deletion to field permission rules.

Actions
Copy link
 #4

Updated by Go MAEDA 5 days ago

  • Subject changed from Deleting a CustomField leaves orphaned workflow records to Deleting an issue custom field does not delete its workflow field permissions
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r25051. Thank you for reporting the issue.

Actions
Copy link

Also available in: Atom PDF