Code Review Plugin 0.2.7 Released.

Added by Haruyuki Iida over 9 years ago

Code Review Plugin 0.2.7 Released.
If you use Redmine 0.8.7, you must upgrade to 0.2.7.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.7.zip

Features:

  • Compatible with Redmine 0.8.7
  • Now code review dialog is resizable.
  • Added link to preview.
  • Compatible with development mode(experimental)

Regards.

Replies (103)

Code Review Plugin 0.3.0 Released. - Added by Haruyuki Iida over 9 years ago

Code Review Plugin 0.3.0 Released.

http://r-labs.googlecode.com/files/redmine_code_review-0.3.0.zip

Features:

  • Now you can assign code review to project members.
  • You can select the target version when you create a new review.
  • Korean translation updated.

Fixed bugs:

  • Can't display code review which has custom field.
  • Broken link appears if reviewed file path includes blank.
  • Error occurs when displaying git branch.
  • Authenticity token error when displaying attached diff file.
    and more.

RE: Code Review Plugin 0.3.0 Released. - Added by Haruyuki Iida over 9 years ago

Haru Iida wrote:

Code Review Plugin 0.3.0 Released.

This version does not work on Redmine 0.8.x.
Please use Redmine 0.9.x or current trunk.

RE: Not working on Redmine 0.9.3 - Added by Haruyuki Iida over 9 years ago

Paryank Kansara wrote:

I have recently upgraded my redmine to version 0.9.3. Now I am getting error on project settings page for which code review is enabled. I have attached exception trace from my log file. I am not a Rails genius :-) so couldn't find the cause of error. Can anyone help for this?

Hi Paryank.

Sorry, I have never seen your error before. But I just released a new version 0.3.0. Please try this one.

RE: Not working on Redmine 0.9.3 - Added by Paryank Kansara over 9 years ago

Haru Iida wrote:

Paryank Kansara wrote:

I have recently upgraded my redmine to version 0.9.3. Now I am getting error on project settings page for which code review is enabled. I have attached exception trace from my log file. I am not a Rails genius :-) so couldn't find the cause of error. Can anyone help for this?

Hi Paryank.

Sorry, I have never seen your error before. But I just released a new version 0.3.0. Please try this one.

I have recently tried 0.3.0 version too. But still no luck :(
I don't know why this error occurs!

RE: Not working on Redmine 0.9.3 - Added by Paryank Kansara over 9 years ago

Haru Iida wrote:

Paryank Kansara wrote:

I have recently upgraded my redmine to version 0.9.3. Now I am getting error on project settings page for which code review is enabled. I have attached exception trace from my log file. I am not a Rails genius :-) so couldn't find the cause of error. Can anyone help for this?

Hi Paryank.

Sorry, I have never seen your error before. But I just released a new version 0.3.0. Please try this one.

Although I am not Rails genius, looking through the code, I can understand cause of error.

vendor/plugins/redmine_code_review/app/views/code_review_settings/_show.html.erb : Line 47

The code is:

<%= f.radio_button(:auto_relation, CodeReviewProjectSetting::AUTORELATION_TYPE_RELATES) %>

Here CodeReviewProjectSetting::AUTORELATION_TYPE_RELATES is numeric

As far as my guess is right, f.radio_button method refers to
lib/tabular_form_builder.rb : Line 28 to 35

which evaluates radio_button as a class method dynamically and

label_for_field(field, options) + super

passes CodeReviewProjectSetting::AUTORELATION_TYPE_RELATES as options which should actually be hash (I don't know what it is called in Ruby).

now on lib/tabular_form_builder.rb : Line 43
options.delete is called. As options is numeric, it throws an error undefined method `delete' for 1:Fixnum

But, after looking all these cool things, my eyes were stuck on lib/tabular_form_builder.rb : Line 28 where code is written as:

(field_helpers - %w(radio_button hidden_field) + %w(date_select)).each do |selector|

Looking into this, I guess radio_button should not be included as dynamic method! I don't know if I am making any mistake in understanding. But as I guess this error occurs only with me, I tried (may be dared :-)) to help you out and I dug it deeper to find out the problem.

Can you please look into it and suggest me a way to resolve this error? I really can't live without Redmine and this plugin :-)

RE: Not working on Redmine 0.9.3 - Added by Paryank Kansara over 9 years ago

Paryank Kansara wrote:

I have recently upgraded my redmine to version 0.9.3. Now I am getting error on project settings page for which code review is enabled. I have attached exception trace from my log file. I am not a Rails genius :-) so couldn't find the cause of error. Can anyone help for this?

Finally got the solution. I had upgraded Ruby to version 1.9.1. I have uninstalled it and installed Ruby 1.8.7. That resolved my issue. Now it works perfectly!

Thank you.

RE: Code Review Plugin 0.2.7 Released. - Added by Alan Liu about 9 years ago

How can I uninstall Code Review Plugin 0.3.0 from Redmine 0.9.3?

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida about 9 years ago

Alan Liu wrote:

How can I uninstall Code Review Plugin 0.3.0 from Redmine 0.9.3?

Simply way, just remove the directory vendor/plugins/redmine_code_review. Then it does not work anymore.

If you want to remove completely, you should do operations below.

Remove following directories.
  • vendor/plugins/redmine_code_review
  • public/plugin_assets/redmine_code_review
Drop fllowing tables from database.
  • code_review_assignments
  • code_review_project_settings
  • code_review_user_settings
  • code_reviews

Remove code_review records from schema_migrations table.
ex. delete from schema_migrations where version LIKE '%redmine_code_review'

RE: Code Review Plugin 0.2.7 Released. - Added by Eric Thomas about 9 years ago

Haru Iida wrote:

Drop fllowing tables from database.
  • code_review_assignments
  • code_review_project_settings
  • code_review_user_settings
  • code_reviews

Remove code_review records from schema_migrations table.
ex. delete from schema_migrations where version LIKE '%redmine_code_review'

Does redmine have hooks set up to perform this using a rake task?

Something like rake db:migrate_plugin down ?

RE: Code Review Plugin 0.2.7 Released. - Added by Ammler _ about 9 years ago

Might it be possible to add code reviews from patches on issues to the same issue?

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida about 9 years ago

Marcel Gmür wrote:

Might it be possible to add code reviews from patches on issues to the same issue?

Sorry, It's impossible.

Code Review Plugin 0.3.1 Released. - Added by Haruyuki Iida about 9 years ago

Code Review Plugin 0.3.1 Released.

http://r-labs.googlecode.com/files/redmine_code_review-0.3.1.zip

Changes

  • Auto assignment functionality was added.
    If you enable this function, code reviews are assigned automatically when codes were committed to repository.
  • Korean translation updated.
  • Few bugs were fixed.

RE: Code Review Plugin 0.2.7 Released. - Added by Ibrahim Awwal about 9 years ago

Hi, I just installed your plugin. I don't see the pencil icons on diffs though; does it not work on git repositories? I don't see a diff link next to each file though, which is strange because I thought it was there before.

Code Review 3.1 -- How do I change the line spacing to closly match the font used for code views - Added by Steven Risner about 9 years ago

I spent about an hour using firebug and was not able to pin down what CSS is used to determine the line spacing on code views.

The side by side views with this plugin produce the correct line spacings, only the annotate or normal code view seem to show lines double (maybe even triple) spaced.

I realize this could be a browser issue, however both IE8 and firefox 3.5.1 have the same problem.

Again the side-by-side diff view is correct.

SS-20100706094835.png - normal view (annotate the same) (15.4 KB)

SS-20100706094848.png - side-by-side (13.7 KB)

RE: Code Review Plugin 0.3.1 Released. - Added by Dylan Yi about 9 years ago

Haru Iida wrote:

Code Review Plugin 0.3.1 Released.

This is my first time install of Code Review and I get the following error when issuing rake db:migrate_plugins RAILS_ENV=production. I have Redmine 0.9.6 with Wiki Extensions and Schedules plugins.

rake db:migrate RAILS_ENV=production --trace
(in /home/WWW/redmine-0.9.6/vendor/plugins/redmine_code_review)
rake aborted!
Don't know how to build task 'db:migrate'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1728:in `[]'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2050:in `invoke_task'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `each'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2023:in `top_level'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2001:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1998:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
/usr/bin/rake:19:in `load'
/usr/bin/rake:19

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida about 9 years ago

Ibrahim Awwal wrote:

Hi, I just installed your plugin. I don't see the pencil icons on diffs though; does it not work on git repositories? I don't see a diff link next to each file though, which is strange because I thought it was there before.

Hi. My plugin works with git repository.
Check your settings.

RE: Code Review 3.1 -- How do I change the line spacing to closly match the font used for code views - Added by Haruyuki Iida about 9 years ago

Steven Risner wrote:
mal code view seem to show lines double (maybe even triple) spaced.

I realize this could be a browser issue, however both IE8 and firefox 3.5.1 have the same problem.

Again the side-by-side diff view is correct.

Hi, Steven.

I checked my plugin with IE8 and it works correctly.
Can you show me a html code of the page?

RE: Code Review 3.1 -- How do I change the line spacing to closly match the font used for code views - Added by Steven Risner about 9 years ago

Yes.

The raw html view also shows large spacing, however for all views.

The side-by-side diffs normally appear as expected.

RE: Code Review Plugin 0.2.7 Released. - Added by Ibrahim Awwal about 9 years ago

Haru Iida wrote:

Ibrahim Awwal wrote:

Hi, I just installed your plugin. I don't see the pencil icons on diffs though; does it not work on git repositories? I don't see a diff link next to each file though, which is strange because I thought it was there before.

Hi. My plugin works with git repository.
Check your settings.

Oh, you're right, now that I checked my logs it's happening because I have redmine installed in a sub-URI mydomain.com/redmine, but the plugin asset paths aren't being fixed for some reason. If anyone could help with this that would be great, but I guess this is a not uncommon problem so I might be able to find the solution myself.

RE: Code Review Plugin 0.3.1 Released. - Added by Haruyuki Iida about 9 years ago

Dylan Yi wrote:

Haru Iida wrote:

Code Review Plugin 0.3.1 Released.

This is my first time install of Code Review and I get the following error when issuing rake db:migrate_plugins RAILS_ENV=production. I have Redmine 0.9.6 with Wiki Extensions and Schedules plugins.

[...]

Hi Dylan.

This error occurs because you executed rake command in a plugin directory.
You should go to "/home/WWW/redmine-0.9.6/" and execute rake again.

thanks.

RE: Code Review Plugin 0.2.7 Released. - Added by Bellatoris Opacus about 9 years ago

I just discovered this plugin and am excited to implement it. But here's what may be a silly question:

If the reviewer creates a review/issue, but it turns out to be a non-issue, how can you close it without a commit?

RE: Code Review Plugin 0.2.7 Released. - Added by Michael Qiu about 9 years ago

I've just installed codeview on redmine 0.9.3 (the one in ubuntu lucid offical repository), added hudson and codereview plugin.
And I use a mercurial repository on local filesystem. The only problem is I can see the pencil icon.
Please check the attached file.
Thanks

log.txt Magnifier (3.13 KB)

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida about 9 years ago

Michael Qiu wrote:

I've just installed codeview on redmine 0.9.3 (the one in ubuntu lucid offical repository), added hudson and codereview plugin.
And I use a mercurial repository on local filesystem. The only problem is I can see the pencil icon.
Please check the attached file.
Thanks

Maybe the directory "public/plugin_assets" is not writable. Check the permission.

RE: Code Review Plugin 0.2.7 Released. - Added by Michael Qiu about 9 years ago

Thanks Haru lida

First, i didn't have a public/plugin_assets folder.
What I've done is:
1. Install by "apt-get install redmine" in an ubuntu lucid server edition
2. Install the code review plugin according to README.rdoc in the package.
3. sudo ln -s /usr/share/redmine/public/ /var/www/redmine and add these 3 lines to /etc/apache2/site-enabled/000-default
PassengerDefaultUser www-data
RailsEnv production
RailsBaseURI /redmine
so I can access redmine by http://hostname/redmine

Now:
1. I've just created public/plugin_assets, tmp, log folders in /usr/share/redmine(ubuntu install redmine in this folder) according to install guide for redmine(I used to conside ubuntu will do it for me).
2. Copy /usr/share/redmine/vendor/plugins/redmine_code_review/assets/* to /usr/share/redmine/public/plugin_assets/redmine_code_review/
Then OK

I still not sure is this the right way?

RE: Code Review 3.1 -- How do I change the line spacing to closly match the font used for code views - Added by Haruyuki Iida almost 9 years ago

Hi Steven.

The raw html view also shows large spacing, however for all views.

The side-by-side diffs normally appear as expected.

Can you try to remove redmine_repo_pygments plugin from your system?
I see the same problem if redmine_repo_pygments was installed and redmine was 1.0.0 or trunk.

1 2 3 4 5 (26-50/103)