Patch #1028

Clean up timelog code

Added by Rocco Stanzione over 14 years ago. Updated over 9 years ago.

Status:ClosedStart date:2008-04-09
Priority:LowDue date:
Assignee:-% Done:


Category:Time tracking
Target version:-


This doesn't have any effect on functionality, but "criteria" is the plural of "criterion", so there's no such word as "criterias". This makes the code difficult to read/work with for a (pedantic) native English speaker. Cleans up the timelog helper, views, controller and functional tests. Tests pass.

cleanup_timelog.diff Magnifier (14.6 KB) Rocco Stanzione, 2008-04-09 21:54


#1 Updated by Toshi MARUYAMA over 11 years ago

  • Category set to Time tracking

#2 Updated by Daniel Felix over 9 years ago

  • Assignee set to Toshi MARUYAMA

Well, I think this one could be closed. As I see for now, there is nothing like criterias or something similar. The patched method is completly rewritten, as I could see.

@ Toshi: If you have no reason against it, this could be set to closed. :-)

#3 Updated by Jean-Philippe Lang over 9 years ago

  • Status changed from New to Closed

Indeed, the patch is obsolete. The proposed change (criterias => criteria) was part of r8026.

#4 Updated by Toshi MARUYAMA over 9 years ago

  • Assignee deleted (Toshi MARUYAMA)

Also available in: Atom PDF