Copy wiki attachments on project copy
|Assignee:||Go MAEDA||% Done:|
When copying a project to a new project, the Wiki pages are copied, but the attachments are not. The attachments on the wiki pages are linked to the previous project, and if, for example, the users accessing the new project have no access to the original project, the images return a 403 error.
#4 Updated by Mizuki ISHIKAWA about 1 year ago
- File add_wiki_attachments_to_copy.patch added
When you copy a project, Issue is copied together with the attached file.
I think that wiki attachments should be copied just like Issue.
By applying the following patch, you can copy the attached file of the wiki.
#5 Updated by Go MAEDA about 1 year ago
Mizuki, thank you for submitting the patch. I tried out your patch and it works fine for me.
I think it is natural that attachments are copied along with wiki pages. In many cases, the content of Wiki page and its attachments are inseparable because attachments are often used to display inline images on the page. The page does not make sense without those images.
Go MAEDA wrote:
I think the test code should also check
disk_filenameattributes to ensure that both attachments are identical and point to the same physical file.
Sorry, you don't have to add such tests because no other tests which copy attachments in test/unit/project_copy_test.rb check those attributes.