Feature #1069

Open Help in a separate tab

Added by Jon Morrow over 14 years ago. Updated 3 months ago.

Status:ClosedStart date:2008-04-15
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:5.1.0
Resolution:Fixed

Description

The help link in the top menu should launch in a new page. As it currently works if a user clicks this link they are taken to redmine.org. If they then navigate around to find their solution they will have to hit the back button numerous times before they are returned to their project page. I was trying to look into this and provide a patch but do not know ruby at all. I will keep looking into and post said patch if I figure it out. BTW - Great software.

help_menu_in_new_window.txt Magnifier - patch for opening help in a new window (837 Bytes) Vijay Kiran, 2008-04-24 14:57

1069.patch Magnifier (1.17 KB) Go MAEDA, 2022-07-11 17:09

1069-v2.patch Magnifier (1.21 KB) Go MAEDA, 2022-07-12 00:14


Related issues

Related to Redmine - Feature #13263: Prevent confusion generated by the top Help link Closed

Associated revisions

Revision 21737
Added by Go MAEDA 3 months ago

Open Help in a separate tab (#1069).

Contributed by Vijay Kiran.

History

#1 Updated by Vijay Kiran over 14 years ago

I'm not sure if this the rightway to do it. But this patch works for me.

#2 Updated by Jon Morrow over 14 years ago

Will take a look at this later today! Thanks!!!

#3 Updated by Jon Morrow over 14 years ago

Me like thanks!

#4 Updated by Toshi MARUYAMA about 8 years ago

  • Related to Feature #13263: Prevent confusion generated by the top Help link added

#5 Updated by Go MAEDA 3 months ago

  • File 1069.patchMagnifier added
  • Target version set to Candidate for next major release

I think also "Powered by Redmine" link in the footer should open a new tab. Attaching a patch.

#6 Updated by Holger Just 3 months ago

Just adding target="_blank" potentially allows the target of the link to interact with the original site which opened the link via the window.opener property to e.g. load a new page there, resulting in the thread of phishing, credential stealing or worse.

This can be circumvented by adding rel="noopener" to these links. While most modern browsers now implicitly set this for any such links, some do not yet. As such, it is still a safer option to explicitly set this too. In your patch, you can set this with

... :target => '_blank', rel => 'noopener' ...

See https://mathiasbynens.github.io/rel-noopener/ for a description of the original issue and its workarounds.

#7 Updated by Go MAEDA 3 months ago

Holger Just wrote:

This can be circumvented by adding rel="noopener" to these links.

Updated the patch. Thank you for pointing it out.

#8 Updated by Holger Just 3 months ago

Looks good to me!

#9 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 5.1.0

Setting the target version to 5.1.0.

#10 Updated by Go MAEDA 3 months ago

  • Subject changed from "Help" link should launch new page. to Open Help in a separate tab
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Also available in: Atom PDF