Project

General

Profile

Actions

Feature #13746

closed

Highlighting of source link target line

Added by Filou Centrinov almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

It would be really useful if the target line from a source link is highlighted.

Example:
Source link: source:tags/2.3.0/Gemfile#L3

The 3rd line should be highlighted:

This could be done with pure css. To make the patch complete also app/views/common/_diff.html.erb and app/views/repositories/annotate.html.erb with appropriate css-modifications should be applied.


Files

line_highlight_target.png (12.5 KB) line_highlight_target.png Filou Centrinov, 2013-04-11 17:14
target_highlight.patch (1.14 KB) target_highlight.patch Filou Centrinov, 2013-04-11 17:15

Related issues

Has duplicate Redmine - Feature #6362: Highlight lines via URL in repository browsings file viewClosed2010-09-11

Actions
Actions #1

Updated by Etienne Massip almost 11 years ago

  • Target version set to Candidate for next major release
Actions #2

Updated by Dipan Mehta almost 11 years ago

+1. This is very nice.

Actions #3

Updated by Filou Centrinov almost 11 years ago

UPDATE: There is no need to patch also app/views/common/_diff.html.erb or app/views/repositories/annotate.html.erb, because we can't set a link to a line of diff code.

Actions #4

Updated by Mischa The Evil almost 11 years ago

Filou Centrinov wrote:

UPDATE: There is no need to patch also app/views/common/_diff.html.erb or app/views/repositories/annotate.html.erb, because we can't set a link to a line of diff code.

You are right about app/views/common/_diff.html.erb which doesn't have the "clickable line #'s". app/views/repositories/annotate.html.erb on the other hand actually has the same 'line #' representation as app/views/common/_file.html.erb so in that way it would make sense to also apply this patch to this view.

Edit by MTE: of course you are right that we can't link to a line in the annotation view...

Ref: #2835 (r2527).

Actions #5

Updated by Jean-Philippe Lang almost 11 years ago

  • Status changed from New to Closed
  • Target version changed from Candidate for next major release to 2.4.0
  • Resolution set to Fixed

Patch committed in r11858, thanks! I've changed the annotate view for consistency. There's no magic link available we can still link to it manually.

Actions #6

Updated by Toshi MARUYAMA over 10 years ago

  • Has duplicate Feature #6362: Highlight lines via URL in repository browsings file view added
Actions

Also available in: Atom PDF