Project

General

Profile

Actions

Feature #13746

closed

Highlighting of source link target line

Feature #13746: Highlighting of source link target line

Added by Filou Centrinov over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
Resolution:
Fixed

Description

It would be really useful if the target line from a source link is highlighted.

Example:
Source link: source:tags/2.3.0/Gemfile#L3

The 3rd line should be highlighted:

This could be done with pure css. To make the patch complete also app/views/common/_diff.html.erb and app/views/repositories/annotate.html.erb with appropriate css-modifications should be applied.


Files

line_highlight_target.png (12.5 KB) line_highlight_target.png Filou Centrinov, 2013-04-11 17:14
target_highlight.patch (1.14 KB) target_highlight.patch Filou Centrinov, 2013-04-11 17:15

Related issues 1 (0 open — 1 closed)

Has duplicate Redmine - Feature #6362: Highlight lines via URL in repository browsings file viewClosedActions

Updated by Etienne Massip over 13 years ago Actions #1

  • Target version set to Candidate for next major release

Updated by Dipan Mehta over 13 years ago Actions #2

+1. This is very nice.

Updated by Filou Centrinov over 13 years ago Actions #3

UPDATE: There is no need to patch also app/views/common/_diff.html.erb or app/views/repositories/annotate.html.erb, because we can't set a link to a line of diff code.

Updated by Mischa The Evil over 13 years ago Actions #4

Filou Centrinov wrote:

UPDATE: There is no need to patch also app/views/common/_diff.html.erb or app/views/repositories/annotate.html.erb, because we can't set a link to a line of diff code.

You are right about app/views/common/_diff.html.erb which doesn't have the "clickable line #'s". app/views/repositories/annotate.html.erb on the other hand actually has the same 'line #' representation as app/views/common/_file.html.erb so in that way it would make sense to also apply this patch to this view.

Edit by MTE: of course you are right that we can't link to a line in the annotation view...

Ref: #2835 (r2527).

Updated by Jean-Philippe Lang over 13 years ago Actions #5

  • Status changed from New to Closed
  • Target version changed from Candidate for next major release to 2.4.0
  • Resolution set to Fixed

Patch committed in r11858, thanks! I've changed the annotate view for consistency. There's no magic link available we can still link to it manually.

Updated by Toshi MARUYAMA almost 13 years ago Actions #6

  • Has duplicate Feature #6362: Highlight lines via URL in repository browsings file view added
Actions

Also available in: PDF Atom