Project

General

Profile

Actions

Defect #14206

closed

Synchronize the lang attribute of the HTML with the display language

Added by Naoya Niwa almost 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
I18n
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Currently, lang attribute of HTML is specified "en" always regardless of the display language.


Files

patch-14206.diff (640 Bytes) patch-14206.diff Naoya Niwa, 2013-06-08 20:38
lang.diff (1.37 KB) lang.diff Toshi MARUYAMA, 2013-06-09 01:05
lang-V2.diff (1.37 KB) lang-V2.diff Toshi MARUYAMA, 2013-06-09 10:44

Related issues

Has duplicate Redmine - Defect #4009: "html" tag's xml:lang always "en" for all languagesClosed2009-10-09

Actions
Actions #1

Updated by Naoya Niwa almost 11 years ago

I made patch.
It gets the value of the lang attribute from I18n.locale.

Just in case, I made ​​sure the existing locales conform to BCP 47 by the following tool.

http://schneegans.de/lv/

Actions #2

Updated by Toshi MARUYAMA almost 11 years ago

  • Status changed from Resolved to New
Actions #3

Updated by Toshi MARUYAMA almost 11 years ago

Redmine defines wrapper "current_language".
source:tags/2.3.1/lib/redmine/i18n.rb#L111

Actions #4

Updated by Toshi MARUYAMA almost 11 years ago

This is a patch with tests.

Actions #5

Updated by Naoya Niwa almost 11 years ago

I appreciate all your help.
At the same time, please forgive my ignorance.

However, I think that should put double quotes around the value of the lang attribute.
I made ​​sure no problem otherwise.

Actions #6

Updated by Toshi MARUYAMA almost 11 years ago

Sorry, this is a patch with double quotes.

Actions #7

Updated by Naoya Niwa almost 11 years ago

  • Status changed from New to Resolved

Thank you very much indeed!

Actions #8

Updated by Toshi MARUYAMA almost 11 years ago

  • Status changed from Resolved to New
Actions #9

Updated by Toshi MARUYAMA almost 11 years ago

  • Target version set to 2.4.0
Actions #10

Updated by Filou Centrinov almost 11 years ago

  • Has duplicate Defect #4009: "html" tag's xml:lang always "en" for all languages added
Actions #11

Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed
Actions

Also available in: Atom PDF