Actions
Defect #14206
closedSynchronize the lang attribute of the HTML with the display language
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Currently, lang attribute of HTML is specified "en" always regardless of the display language.
Files
Related issues
       Updated by Naoya Niwa over 12 years ago
      Updated by Naoya Niwa over 12 years ago
      
    
    - File patch-14206.diff patch-14206.diff added
- Status changed from New to Resolved
I made patch.
It gets the value of the lang attribute from I18n.locale.
Just in case, I made sure the existing locales conform to BCP 47 by the following tool.
       Updated by Toshi MARUYAMA over 12 years ago
      Updated by Toshi MARUYAMA over 12 years ago
      
    
    Redmine defines wrapper "current_language".
source:tags/2.3.1/lib/redmine/i18n.rb#L111
       Updated by Toshi MARUYAMA over 12 years ago
      Updated by Toshi MARUYAMA over 12 years ago
      
    
    
    This is a patch with tests.
       Updated by Naoya Niwa over 12 years ago
      Updated by Naoya Niwa over 12 years ago
      
    
    I appreciate all your help.
At the same time, please forgive my ignorance.
However, I think that should put double quotes around the value of the lang attribute.
I made sure no problem otherwise.
       Updated by Toshi MARUYAMA over 12 years ago
      Updated by Toshi MARUYAMA over 12 years ago
      
    
    - File lang-V2.diff lang-V2.diff added
Sorry, this is a patch with double quotes.
       Updated by Naoya Niwa over 12 years ago
      Updated by Naoya Niwa over 12 years ago
      
    
    - Status changed from New to Resolved
Thank you very much indeed!
       Updated by Filou Centrinov over 12 years ago
      Updated by Filou Centrinov over 12 years ago
      
    
    - Has duplicate Defect #4009: "html" tag's xml:lang always "en" for all languages added
       Updated by Jean-Philippe Lang over 12 years ago
      Updated by Jean-Philippe Lang over 12 years ago
      
    
    - Status changed from New to Closed
- Resolution set to Fixed
Actions