Project

General

Profile

Actions

Defect #14792

closed

Don't add a display name and extra angle brackets in List-Id header field

Added by Jan Niggemann (redmine.org team member) over 10 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Email notifications
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Continued from here: http://www.redmine.org/boards/1/topics/39232

If Setting.mail_from already contains a (valid) address like "Ticket System <>", then it's wrong to insert angle brackets in this line http://www.redmine.org/projects/redmine/repository/revisions/11988/entry/trunk/app/models/mailer.rb#L389

It creates List-Ids of the form "<Ticket System <>>", which, if I understand correctly, are not RFC compliant: http://www.ietf.org/rfc/rfc2919.txt

See also #10888 and propsed patch #13359


Files

fix-14792.diff (1.22 KB) fix-14792.diff Go MAEDA, 2019-02-13 04:01

Related issues

Related to Redmine - Patch #13359: Better List-Id to help aid Gmail filteringNew

Actions
Related to Redmine - Defect #30785: Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display nameClosedGo MAEDA

Actions
Related to Redmine - Feature #5913: Authors name in from address of email notificationsClosedGo MAEDA2010-07-20

Actions
Actions

Also available in: Atom PDF