Patch #16314
Redirect back is overheated
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | - | |||
| Target version: | - |
Description
Take a look at these code lines:
source:trunk/app/controllers/application_controller.rb@13036#L368
It is not used at all.
source:trunk/app/controllers/application_controller.rb@13036#L399
It uses same functionality that method above (relies on HTTP_REFERER).
source:trunk/app/helpers/application_helper.rb@13036#L1100
It could be replaced with `helper_method :back_url`.
source:trunk/app/controllers/application_controller.rb@13036#L390
This condition is never satisfied. I did not find an usage.
History
#1
Updated by Jean-Philippe Lang over 8 years ago
- Tracker changed from Defect to Patch
- Assignee set to Jean-Philippe Lang
Anton Orel wrote:
Take a look at these code lines:
source:app/controllers/application_controller.rb#L368
It is not used at all.
It's used at least in ContextMenusController.
source:app/controllers/application_controller.rb#L399
It uses same functionality that method above (relies on HTTP_REFERER).
Not the same functionnality, one relies on the :back_url param, the other one on HTTP_REFERER. But please provide a patch if you think they can be merged in a single one.
source:app/helpers/application_helper.rb#L1100
It could be replaced with `helper_method :back_url`.
Please provide a patch.
source:app/controllers/application_controller.rb#L390
This condition is never satisfied. I did not find an usage.
Used at least in AccountController.
#2
Updated by Toshi MARUYAMA about 8 years ago
- Description updated (diff)