Project

General

Profile

Actions

Defect #16989

closed

Inline images in email does not appear when thumbnail macro is used.

Added by Bahri Yardim about 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Email notifications
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Redmine v2.5.1

When using

{{thumbnail(filename.png)}}
in a comment, the email sent to notify related users does not show the image. The <img> source starts with /attachments.
This is because relative url is used in thumbnail macro when processing the text.

To fix this, we should use the url_for argument :only_path => false, so that the generated urls are absolute.

The fix is in the patch and we are using it confidently in our system.


Files


Related issues

Related to Redmine - Feature #2770: Display of inline attached images in email notificationReopened2009-02-18

Actions
Actions #1

Updated by Go MAEDA about 10 years ago

Confirmed the problem with Redmine 2.5.1 and this patch addresses the problem.

Actions #2

Updated by Toshi MARUYAMA about 10 years ago

  • Target version set to 2.5.2
Actions #3

Updated by Go MAEDA about 10 years ago

Related to #2770.

The patch attached on this issue cannot display images on non-public projects.

Actions #4

Updated by Toshi MARUYAMA almost 10 years ago

  • Tracker changed from Patch to Defect
Actions #5

Updated by Toshi MARUYAMA almost 10 years ago

  • Related to Feature #2770: Display of inline attached images in email notification added
Actions #6

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r13218, urls now include host name.

Actions #7

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF