Project

General

Profile

Actions
Copy link

Feature #17380

closed

Move project sidebar content to a partial

Added by Jérôme BATAILLE almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
UI
Target version:
2.6.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

It's more convenient to override the sidebar in plugins

Files

RM_17380_project_show_add_a_sidebar_partial_RM_V2.5.diff (1.74 KB) RM_17380_project_show_add_a_sidebar_partial_RM_V2.5.diff Jérôme BATAILLE, 2014-07-04 10:48
Actions
Copy link
 #2

Updated by Daniel Felix almost 11 years ago

Would be good, as the same approach is taken for the issues.

Actions
Copy link
 #3

Updated by Toshi MARUYAMA almost 11 years ago

  • Target version set to 2.6.0
Actions
Copy link
 #4

Updated by Mischa The Evil almost 11 years ago

Jérôme BATAILLE wrote:

Here is the patch

Nice. Thanks for sharing.

Daniel Felix wrote:

Would be good, as the same approach is taken for the issues.

Daniel, am I missing something? AFAICT the sidebar code for issues (both #index and #show) is already located in a dedicated partial (source:/trunk/app/views/issues/_sidebar.html.erb).

Actions
Copy link
 #5

Updated by Jérôme BATAILLE almost 11 years ago

Mischa, you're right, but the content of the partial is totally different.

Actions
Copy link
 #6

Updated by Jean-Philippe Lang almost 11 years ago

  • Subject changed from Project / show add a sidebar partial to Move project sidebar content to a partial
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed in r13393.

Actions
Copy link
 #7

Updated by Jérôme BATAILLE almost 11 years ago

Thanks a lot !

Actions
Copy link

Also available in: Atom PDF