Defect #17517
closed
Attempting to Add a Related Issue Multiple Times Sequentially Causes 500
Added by Zach Auclair over 11 years ago.
Updated over 7 years ago.
Description
When pressing "Add" after typing a related issue, the form ajax submits but does not prevent further ajax submits while the request is being processed.
As a result of this, clicking "add" multiple times quickly will cause sequential requests to link an issue (after the first) to fail; along with this, the results of the last post are displayed (meaning the first successful add of a related issue may be hidden).
proposed patch:
diff --git a/app/views/issue_relations/_form.html.erb b/app/views/issue_relations/_form.html.erb
index 29b7f0f..ff80e47 100644
--- a/app/views/issue_relations/_form.html.erb
+++ b/app/views/issue_relations/_form.html.erb
@@ -5,7 +5,7 @@
<span id="predecessor_fields" style="display:none;">
<%= l(:field_delay) %>: <%= f.text_field :delay, :size => 3 %> <%= l(:label_day_plural) %>
</span>
-<%= submit_tag l(:button_add) %>
+<%= submit_tag l(:button_add), :disable_with => l(:button_add) %>
<%= link_to_function l(:button_cancel), '$("#new-relation-form").hide();'%>
</p>
- Target version set to 2.5.3
- Target version changed from 2.5.3 to 2.6.0
- Status changed from New to Needs feedback
- Assignee set to Jean-Philippe Lang
The proposed fix has a side effect with Firefox (tested with 24 ESR):
- go to an issue, add a relation
- hit F5
- click on the 'Add' link to add another relation => the 'Add' button is disabled
Problem doesn't occur if step 2 is omitted.
BTW, I don't get 500 errors when hitting the button multiple times. I only get a proper validation error message. Can you post your 500 error stack trace ?
- Target version changed from 2.6.0 to Candidate for next minor release
It seems that the data-disable-with attribute is enabled by default in Rails 5. There are some examples here.
Also, I tested this issue on the current trunk and works as expected in the major browsers (Safari, Chrome and Firefox) on OS X. I propose to mark this ticket as fixed by #23630.
- Assignee deleted (
Jean-Philippe Lang)
- Target version changed from Candidate for next minor release to 4.0.0
Considering that the issue seems to be fixed in version 4.0.0 by the migration to Rails 5.1, I would like a second opinion before closing it.
- Status changed from Needs feedback to Closed
- Resolution set to Fixed
Also available in: Atom
PDF