Project

General

Profile

Actions

Defect #18306

closed

Second, different IssueStatusesControllerTest#test_destroy_should_block_if_status_in_use introduced in r13535

Added by Mischa The Evil over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

r13535 introduces a second and different IssueStatusesControllerTest#test_destroy_should_block_if_status_in_use (source:/trunk/test/functional/issue_statuses_controller_test.rb@13569#L110) while a method with that exact name is already defined at source:/trunk/test/functional/issue_statuses_controller_test.rb@13569#L99.
If I understand the code correctly, I think naming them respectively:
  • IssueStatusesControllerTest#test_destroy_with_default_status_id_should_block_if_status_in_use and
  • IssueStatusesControllerTest#test_destroy_with_status_id_should_block_if_status_in_use

better describes the tests intentions.

I'm not entirely sure if this is a real problem or not, but I thought it might be worth an issue.

Actions #1

Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r13575, thanks for poiting this out!

Actions

Also available in: Atom PDF