Defect #18922
closedrdm-mailhandler.rb should catch EOFError
0%
Description
rdm-mailhandler.rb should catch EOFError in addition to SystemCallError at source:trunk/extra/mail_handler/rdm-mailhandler.rb@13872#L132.
If communications between rdm-mailhandler.rb and Redmine are terminated while rdm-mailhandler.rb talking to Redmine, Net::HTTP raises EOFError and rdm-mailhandler stops unexpectedly because it does not catch EOFError. The email will be bounced.
We can avoid the preceding by this patch. The email will be deferred, not bounced.
Files
Updated by Jean-Philippe Lang over 9 years ago
Maybe we could even catch IOError which is the superclass of EOFError?
Updated by Go MAEDA over 9 years ago
Jean-Philippe Lang wrote:
Maybe we could even catch IOError which is the superclass of EOFError?
Indeed. To deal with a variety of situations, catching IOError is better solition.
Thank you for pointing it out.
Updated by Go MAEDA over 9 years ago
- File catch-IOError.diff catch-IOError.diff added
Here is a new patch. Catches IOError instead of EOFError.
Updated by Jean-Philippe Lang over 9 years ago
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.6.2
- Resolution set to Fixed
Patch committed in r13961, thanks.
Updated by Jean-Philippe Lang over 9 years ago
- Status changed from Resolved to Closed