Project

General

Profile

Actions
Copy link

Defect #20068

closed

[Gemfile] Wrong bundler syntaxis used in platforms declaration for tzinfo-data gem

Added by Mischa The Evil almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Invalid
Affected version:
3.0.3

Description

source:/trunk/Gemfile@14300#L18 declares the platforms as:

gem 'tzinfo-data', platforms: [:mingw, :x64_mingw, :mswin, :jruby]

which should1 be declared as:

gem 'tzinfo-data', platforms => [:mingw, :x64_mingw, :mswin, :jruby]

So this little patch:

Index: Gemfile
===================================================================
--- Gemfile    (revision 14300)
+++ Gemfile    (working copy)
@@ -15,7 +15,7 @@
 gem "actionpack-xml_parser" 

 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-gem 'tzinfo-data', platforms: [:mingw, :x64_mingw, :mswin, :jruby]
+gem 'tzinfo-data', platforms => [:mingw, :x64_mingw, :mswin, :jruby]
 gem "rbpdf", "~> 1.18.5" 

 # Optional gem for LDAP authentication

would fix issues like for example mentioned in ERROR: bundle install --without development test.

1 per http://bundler.io/v1.9/man/gemfile.5.html#PLATFORMS-platforms-

Actions
Copy link
 #1

Updated by Toshi MARUYAMA almost 9 years ago

  • Status changed from New to Needs feedback
Actions
Copy link
 #2

Updated by Mischa The Evil almost 9 years ago

  • Resolution set to Invalid

Toshi MARUYAMA wrote in RE: ERROR: bundle install --without development test:

"platforms:" is valid Ruby 1.9 hash syntax.

Ah, you are right indeed. The examples given in the bundler doc are all using 'old-style' hash syntaxis, which distracted me and made me jumping to a wrong conclusion.
On the other hand, this gem declaration is the only one using this syntax where the others (defined within the case structure at source:/trunk/Gemfile@14328#L61) are (still) using regular/old-style hash syntax, as such breaking the consistency of the used code syntax. If you are ok with that, I'd like you to close this issue.

Off-topic: Toshi, could you please replace the tab in source:trunk/app/controllers/mail_handler_controller.rb@14328#L21 which is introduced in r14314 with spaces? I don't want to open a new issue for such a small thing. The other thing: what do you think of the fact that the form introduced in that revision is not i18n'ed? Would it be worth the effort of adding so much - difficult to maintain - strings to the locales?

Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from Needs feedback to Closed

Mischa The Evil wrote:

Off-topic: Toshi, could you please replace the tab in source:trunk/app/controllers/mail_handler_controller.rb@14328#L21 which is introduced in r14314 with spaces? I don't want to open a new issue for such a small thing.

This was fixed with your patch in r14365.

The other thing: what do you think of the fact that the form introduced in that revision is not i18n'ed? Would it be worth the effort of adding so much - difficult to maintain - strings to the locales?

It's for testing purpose and not for end users, I think we don't need to i18n this form. Field names match mail_handler script options names.

Actions
Copy link

Also available in: Atom PDF