Feature #20221
closed
Time entry query : column week
0%
Files
Related issues
Updated by Jérôme BATAILLE about 10 years ago
Here is the patch working on any version of Redmine.
Please feel free to integrate this straightforward patch
Updated by Toshi MARUYAMA almost 10 years ago
Updated by Jérôme BATAILLE almost 10 years ago
- File RM_20221_Time_entry_query_column_week_Tests.diff RM_20221_Time_entry_query_column_week_Tests.diff added
Here is a patch, only the unit test, there is no controller test about queries available columns
Updated by Jean-Philippe Lang almost 10 years ago
Does it make sense to display the week number without the year? Sorting on this column will result in time entries from different years appear with the same week.
Updated by Jérôme BATAILLE almost 10 years ago
Jean-Philippe Lang wrote:
Does it make sense to display the week number without the year? Sorting on this column will result in time entries from different years appear with the same week.
I don't see a use case that makes this sort useful, but on the other hand displaying this column is useful to have the week number without duplicating informations in other columns (spent_on). The yyyy-ww sort can be done with spent_on.
Thank to have added this patch to 3.2.0
If you have some time to review my other pending patches I will be very pleased !
Updated by Jean-Philippe Lang almost 10 years ago
Jérôme BATAILLE wrote:
I don't see a use case that makes this sort useful
Just asking... because the patch makes it sortable.
Updated by Jérôme BATAILLE almost 10 years ago
Jean-Philippe Lang wrote:
Just asking... because the patch makes it sortable.
We are at the frontier of YAGNI :-) I can't see a use case, but perhaps some folks will, and adding the sort costs nothing.
Updated by Jean-Philippe Lang almost 10 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Column added in r14723. But sort is done on spent_on, as sorting by week number does make no sense when we have time entries on several years.
Updated by Toshi MARUYAMA almost 8 years ago
- Related to Defect #26780: Translation for label_week in time report is not working added