Redmine

• source:tags/3.1.0/test/unit/time_entry_query_test.rb
• source:tags/3.1.0/test/functional/timelog_controller_test.rb

Does it make sense to display the week number without the year? Sorting on this column will result in time entries from different years appear with the same week.

Jean-Philippe Lang wrote:

Does it make sense to display the week number without the year? Sorting on this column will result in time entries from different years appear with the same week.

I don't see a use case that makes this sort useful, but on the other hand displaying this column is useful to have the week number without duplicating informations in other columns (spent_on). The yyyy-ww sort can be done with spent_on.

Thank to have added this patch to 3.2.0

If you have some time to review my other pending patches I will be very pleased !

Jérôme BATAILLE wrote:

I don't see a use case that makes this sort useful

Just asking... because the patch makes it sortable.

Jean-Philippe Lang wrote:

Just asking... because the patch makes it sortable.

We are at the frontier of YAGNI :-) I can't see a use case, but perhaps some folks will, and adding the sort costs nothing.

Thanks a lot !