Feature #2048

Code Review Module

Added by Gabriel Moreira almost 12 years ago. Updated 7 months ago.

Status:NewStart date:2008-10-18
Priority:NormalDue date:
Assignee:-% Done:

20%

Category:Plugin Request
Target version:-
Resolution:

Description

Create a integrated code review module like atlassian crucible, reviewboard, rietveld, mondrian etc...

changeset_journals_v1.diff Magnifier - against revsion 2824 (9.78 KB) Aaron Soules, 2009-07-21 02:53


Related issues

Related to Redmine - Feature #7747: Add capability to ask\accept\reject review of patches (fl... New 2011-03-01
Related to Redmine - Feature #1339: Comments on revisions New 2008-05-31
Duplicated by Redmine - Feature #469: Code Review/Approve workflow? Closed

History

#1 Updated by Lane Roathe almost 12 years ago

+1 - this would be a very good feature for those of us using Redmine for project planning/management vs simple bug tracking.

#2 Updated by Anonymous almost 12 years ago

+1

#3 Updated by Philippe Lafoucrière almost 12 years ago

+1, agree with Lane

#4 Updated by Thomas Lecavelier almost 12 years ago

Should be a plugin, not a feature: redmine has to stay as lightweight as possible out of the box.

#5 Updated by Octavian Cacina almost 12 years ago

+1, A fist step: allow comments on Changesets, it would be a big improvement in this direction.

#6 Updated by Gabriel Moreira almost 12 years ago

I agree. Allow comments on Changesets is more simple to begin.

Review Board: OpenSource (
http://www.review-board.org/

Atlassian Crucible Commercial (Has more features then Review Board)
http://www.atlassian.com/software/crucible/screenshots/default.jsp

#7 Updated by Aaron Soules over 11 years ago

Agreed, I use redmine at work for several projects and we would benefit from repository comments. I would like to replicate the github comment system, where you can tag your comment with a specific line number. That way my team could use it as a lightweight code review system. Once that works, I would like to add a feature that allows the commiter to request reviews from other users.

#8 Updated by Oleg Lozinskij over 11 years ago

+1

#9 Updated by Silas Sewell over 11 years ago

+1

#10 Updated by Alexey Lapitksy over 11 years ago

+1

#11 Updated by Aaron Soules about 11 years ago

I wrote the part for adding comments to a changesets (using the existing Journal model). I couldn't figure out how to get a checkbox to show up in the email notification prefs, but I also wrote the code that sends an email to the revision committer (and other users who have commented) when someone comments on a revision.

Please let me know what I can improve/fix, This is my first contribution to Redmine :)

I've attached my diff against r2824

#12 Updated by Aaron Soules about 11 years ago

hmm, didn't see that code review plugin... guess this issue got a little stale :) I still like the github interface better, which is what I was going for. Any thoughts? Should this code stay outside of Redmine Core?

#13 Updated by Anton Nepomnyaschih almost 11 years ago

There is code review plugin for redmine. It looks great: http://www.redmine.org/boards/3/topics/5878

#14 Updated by Etienne Massip over 8 years ago

  • Category set to Plugin Request

#15 Updated by Dipan Mehta over 7 years ago

You can use the Code Review plugin. It works very well and quite the perfect module.

#16 Updated by rm user almost 7 years ago

Dipan Mehta wrote:

You can use the Code Review plugin. It works very well and quite the perfect module.

no it's not giving accept/reject functionality and not e-mailing status to the person who commited into repository.

you can only comment on specific revision line or whole revision (not really convinient because it creates an issue per each line).

in other words: its not suitable for using in production environment.

i read a lot about gerrit/reviewboard might give it a try later.

#17 Updated by pasquale [:dedalus] 7 months ago

+1
nowadays from a developer team perspective this is a must have feature.

#18 Updated by Robert Schneider 7 months ago

@pasquale : there is this plugin which is compatible with version 4.0: https://www.redmine.org/plugins/redmine_code_review

#19 Updated by pasquale [:dedalus] 7 months ago

Hi Robert, thanks for your answer. I was looking for something similar to Review Board core or integration.
Do you use redmine_code_review in your daily workflow with your peers?

#20 Updated by Robert Schneider 7 months ago

No, I have no experience with it. Never done Code Reviews, unfortunately.

#21 Updated by rm user 7 months ago

pasquale [:dedalus] wrote:

+1
nowadays from a developer team perspective this is a must have feature.

I'd recommend using gitlab with pull requests, much better for code review. Also you can integrate gitlab with redmine by disabling issues in the gitlab and linking them to your redmine installation.

#22 Updated by pasquale [:dedalus] 7 months ago

GitLab Is very good, but I'm on Mercurial repositories.

Also available in: Atom PDF