Code Review Module
Create a integrated code review module like atlassian crucible, reviewboard, rietveld, mondrian etc...
#6 Updated by Gabriel Moreira over 13 years ago
I agree. Allow comments on Changesets is more simple to begin.
Review Board: OpenSource (
Atlassian Crucible Commercial (Has more features then Review Board)
#7 Updated by Aaron Soules over 13 years ago
Agreed, I use redmine at work for several projects and we would benefit from repository comments. I would like to replicate the github comment system, where you can tag your comment with a specific line number. That way my team could use it as a lightweight code review system. Once that works, I would like to add a feature that allows the commiter to request reviews from other users.
#11 Updated by Aaron Soules almost 13 years ago
- File changeset_journals_v1.diff added
- % Done changed from 0 to 20
I wrote the part for adding comments to a changesets (using the existing Journal model). I couldn't figure out how to get a checkbox to show up in the email notification prefs, but I also wrote the code that sends an email to the revision committer (and other users who have commented) when someone comments on a revision.
Please let me know what I can improve/fix, This is my first contribution to Redmine :)
I've attached my diff against r2824
#16 Updated by rm user over 8 years ago
Dipan Mehta wrote:
You can use the Code Review plugin. It works very well and quite the perfect module.
no it's not giving accept/reject functionality and not e-mailing status to the person who commited into repository.
you can only comment on specific revision line or whole revision (not really convinient because it creates an issue per each line).
in other words: its not suitable for using in production environment.
i read a lot about gerrit/reviewboard might give it a try later.
#18 Updated by Robert Schneider over 2 years ago
@pasquale : there is this plugin which is compatible with version 4.0: https://www.redmine.org/plugins/redmine_code_review
#21 Updated by rm user over 2 years ago
pasquale [:dedalus] wrote:
nowadays from a developer team perspective this is a must have feature.
I'd recommend using gitlab with pull requests, much better for code review. Also you can integrate gitlab with redmine by disabling issues in the gitlab and linking them to your redmine installation.
#23 Updated by pasquale [:dedalus] about 1 year ago
- File moz-phab.png added
As Idea, recently bugzilla has integrated an external code review tool (Phabricator) with this approach and now a specific section is present in the issue page as show under:
A similar implementation on Redmine side, could be a great improvement\step forward for the community.