Project

General

Profile

Actions

Feature #2048

open

Code Review Module

Added by Gabriel Moreira over 15 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Plugin Request
Target version:
-
Start date:
2008-10-18
Due date:
% Done:

20%

Estimated time:
Resolution:

Description

Create a integrated code review module like atlassian crucible, reviewboard, rietveld, mondrian etc...


Files

changeset_journals_v1.diff (9.78 KB) changeset_journals_v1.diff against revsion 2824 Aaron Soules, 2009-07-21 02:53
moz-phab.png (71.6 KB) moz-phab.png pasquale [:dedalus], 2021-04-17 09:31

Related issues

Related to Redmine - Feature #7747: Add capability to ask\accept\reject review of patches (flag support on attachments)New2011-03-01

Actions
Related to Redmine - Feature #1339: Comments on revisionsNew2008-05-31

Actions
Has duplicate Redmine - Feature #469: Code Review/Approve workflow?Closed

Actions
Actions #1

Updated by Lane Roathe over 15 years ago

+1 - this would be a very good feature for those of us using Redmine for project planning/management vs simple bug tracking.

Actions #2

Updated by Anonymous over 15 years ago

+1

Actions #3

Updated by Philippe Lafoucrière over 15 years ago

+1, agree with Lane

Actions #4

Updated by Thomas Lecavelier over 15 years ago

Should be a plugin, not a feature: redmine has to stay as lightweight as possible out of the box.

Actions #5

Updated by Octavian Cacina over 15 years ago

+1, A fist step: allow comments on Changesets, it would be a big improvement in this direction.

Actions #6

Updated by Gabriel Moreira over 15 years ago

I agree. Allow comments on Changesets is more simple to begin.

Review Board: OpenSource (
http://www.review-board.org/

Atlassian Crucible Commercial (Has more features then Review Board)
http://www.atlassian.com/software/crucible/screenshots/default.jsp

Actions #7

Updated by Aaron Soules over 15 years ago

Agreed, I use redmine at work for several projects and we would benefit from repository comments. I would like to replicate the github comment system, where you can tag your comment with a specific line number. That way my team could use it as a lightweight code review system. Once that works, I would like to add a feature that allows the commiter to request reviews from other users.

Actions #8

Updated by Oleg Lozinskij about 15 years ago

+1

Actions #9

Updated by Silas Sewell about 15 years ago

+1

Actions #10

Updated by Alexey Lapitksy about 15 years ago

+1

Actions #11

Updated by Aaron Soules almost 15 years ago

I wrote the part for adding comments to a changesets (using the existing Journal model). I couldn't figure out how to get a checkbox to show up in the email notification prefs, but I also wrote the code that sends an email to the revision committer (and other users who have commented) when someone comments on a revision.

Please let me know what I can improve/fix, This is my first contribution to Redmine :)

I've attached my diff against r2824

Actions #12

Updated by Aaron Soules almost 15 years ago

hmm, didn't see that code review plugin... guess this issue got a little stale :) I still like the github interface better, which is what I was going for. Any thoughts? Should this code stay outside of Redmine Core?

Actions #13

Updated by Anton Nepomnyaschih over 14 years ago

There is code review plugin for redmine. It looks great: http://www.redmine.org/boards/3/topics/5878

Actions #14

Updated by Etienne Massip over 12 years ago

  • Category set to Plugin Request
Actions #15

Updated by Dipan Mehta about 11 years ago

You can use the Code Review plugin. It works very well and quite the perfect module.

Actions #16

Updated by rm user over 10 years ago

Dipan Mehta wrote:

You can use the Code Review plugin. It works very well and quite the perfect module.

no it's not giving accept/reject functionality and not e-mailing status to the person who commited into repository.

you can only comment on specific revision line or whole revision (not really convinient because it creates an issue per each line).

in other words: its not suitable for using in production environment.

i read a lot about gerrit/reviewboard might give it a try later.

Actions #17

Updated by pasquale [:dedalus] over 4 years ago

+1
nowadays from a developer team perspective this is a must have feature.

Actions #18

Updated by Robert Schneider over 4 years ago

@pasquale : there is this plugin which is compatible with version 4.0: https://www.redmine.org/plugins/redmine_code_review

Actions #19

Updated by pasquale [:dedalus] over 4 years ago

Hi Robert, thanks for your answer. I was looking for something similar to Review Board core or integration.
Do you use redmine_code_review in your daily workflow with your peers?

Actions #20

Updated by Robert Schneider over 4 years ago

No, I have no experience with it. Never done Code Reviews, unfortunately.

Actions #21

Updated by rm user about 4 years ago

pasquale [:dedalus] wrote:

+1
nowadays from a developer team perspective this is a must have feature.

I'd recommend using gitlab with pull requests, much better for code review. Also you can integrate gitlab with redmine by disabling issues in the gitlab and linking them to your redmine installation.

Actions #22

Updated by pasquale [:dedalus] about 4 years ago

GitLab Is very good, but I'm on Mercurial repositories.

Actions #23

Updated by pasquale [:dedalus] about 3 years ago

As Idea, recently bugzilla has integrated an external code review tool (Phabricator) with this approach and now a specific section is present in the issue page as show under:

A similar implementation on Redmine side, could be a great improvement\step forward for the community.

Actions

Also available in: Atom PDF