Feature #1339

Comments on revisions

Added by Daniel Netzer almost 9 years ago. Updated over 1 year ago.

Status:NewStart date:2008-05-31
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:Candidate for next major release
Resolution:

Description

As described in the forum: Feature: Comments on revisions? - I think it would be great to have the ability to comment on revisions (or commits). I would see this as an improvement in the collaboration between developers - for example comment the commiters coding style or way of implementing something. This is of course somehow related to a discussion in the forum but I think having direct comments (discussion) on tickets would be more intuitive.


Related issues

Related to Redmine - Feature #2048: Code Review Module New 2008-10-18
Related to Redmine - Feature #1687: Ability to quote a patch in a comment New 2008-07-27
Duplicated by Redmine - Feature #2545: Revision Comments Closed
Duplicated by Redmine - Feature #3273: be able to comment on repostory checkins Closed 2009-04-30
Duplicated by Redmine - Feature #13278: It'd be nice to be able to comment on the commit differen... Closed

History

#1 Updated by Toshi MARUYAMA about 6 years ago

  • Category set to SCM

#2 Updated by Jurgens du Toit over 5 years ago

Any update / progress on this?

#3 Updated by Etienne Massip over 5 years ago

  • Target version set to Candidate for next major release

Would be a great addition.

#4 Updated by Radek Karban almost 5 years ago

+1

#5 Updated by Denny Schäfer over 4 years ago

+1

#6 Updated by Toshi MARUYAMA about 4 years ago

Redmine Code Review Plugin has this feature.
http://www.r-labs.org/projects/r-labs/wiki/Code_Review_en

#7 Updated by Pavel Lautsevich about 4 years ago

+1

#8 Updated by Pavel Lautsevich about 4 years ago

+1

#9 Updated by Ivan Cenov about 4 years ago

Toshi MARUYAMA wrote:

Redmine Code Review Plugin has this feature.
http://www.r-labs.org/projects/r-labs/wiki/Code_Review_en

This plugin is very good solution. I think there is no need to implement other functionality for comments. Moreover, commits come with comments from SCM.

-1

#10 Updated by Prof. Dr. YoMan about 4 years ago

+1
I would love to see this bundled in redmine. Right now not having it (ok, plugin) is the only cause for me to install gitlab.

#11 Updated by Dipan Mehta about 4 years ago

+1. This is really a good idea.

I would like to point out one thing: While this sounds like a close equivalent of "Code Review Plugin" it is certainly not.

  1. Code Reviews are NOT limited to only 1 revision but could be for an entire set of Revisions
  2. Code Review is a formal process - and usually it implies that code-reviews are done typically in a project's collective decisions, approvals and it involves many people beyond developers!
  3. Usually, "Code Review Assignments" registers an issue which then someone really have to attend, follow through its formal process, may be include tests and so on.
  4. At best "Comments on the Revisions" - are actually a poor replacements for the Code Review. - but that is the reason why they are very important.

The reason why 'Comments on Revisions' is so important is that it allows informal communication between those involved without having to worry about organization's other processes!

+1 This feature must be there as Redmine's ability.

#12 Updated by budo kaiman over 1 year ago

+1

#13 Updated by Toshi MARUYAMA over 1 year ago

  • Description updated (diff)

#14 Updated by Toshi MARUYAMA over 1 year ago

  • Description updated (diff)

#15 Updated by Toshi MARUYAMA 6 months ago

  • Related to Feature #1687: Ability to quote a patch in a comment added

Also available in: Atom PDF