Patch #21110

Keep anchor (i.e. to a specific issue note) throughout login

Added by Jens Krämer about 3 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Accounts / authentication
Target version:3.2.0

Description

Problem

When not logged in and following a 'deep' link to a specific issue note, the user is first redirected to the sign in form, and after successful login the user is just sent to the top of the issue page because the anchor (i.e. #note-23) got lost along the way.

Solution

The anchor is not transferred to the server, so in order to keep it we need to introduce a bit of Javascript to preserve it when the login form is submitted.

keep_anchor_on_signin.diff Magnifier (1.06 KB) Jens Krämer, 2015-10-30 06:21

Associated revisions

Revision 14767
Added by Jean-Philippe Lang about 3 years ago

Keep anchor (i.e. to a specific issue note) throughout login (#21110).

Patch by Jens Krämer.

History

#1 Updated by Jean-Philippe Lang about 3 years ago

Works fine with Firefox, but doesn't work with Chrome 46.

#2 Updated by Jens Krämer about 3 years ago

Oh. Any JS errors? Chrome 45 works.

#3 Updated by Jens Krämer about 3 years ago

I just checked in Chrome 47 / Linux and had a colleague check Chrome 46 / OSX 10.9 and both worked fine as well.

#4 Updated by Jean-Philippe Lang about 3 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.2.0

Sorry, my fault. Committed in r14767, thanks.

#5 Updated by Christian Damen almost 2 years ago

Workin' great. Thanks a lot Jean-Philippe :-)

Checked with Chrome 56, IE 11, Firefox 50.1

Also available in: Atom PDF