Feature #22058
Show image attachments and repo entries instead of downloading them
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Attachments | |||
| Target version: | 3.3.0 | |||
| Resolution: | Fixed |
Description
For text file attachments and text files in a repository, we have a nice inline display in Redmine that even shows line numbers.
Images however are always just downloaded. It would be nice if they were displayed as well.
Patch #21847_ Let mobile header be fixed - Redmine 2016-02-17 16-39-27.png (115 KB)
0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch 
(3.32 KB)
0002-Whitespace-only-change.patch
(2.14 KB)
image_preview_in_redmine.jpg (370 KB)
0004-Whitespace-only.patch
(949 Bytes)
0003-Add-inline-image-preview-display-for-attachments-and.patch
(4.97 KB)
Associated revisions
Reduce view code duplication by using a nested layout for file rendering (#22058).
Patch by Jan Schulz-Hofen.
Whitespace only change (#22058).
Patch by Jan Schulz-Hofen.
Add inline image preview/display for attachments and repository entries (#22058).
Patch by Jan Schulz-Hofen.
Whitespace only change (#22058).
Patch by Jan Schulz-Hofen.
Fix max width and adds a top margin (#22058).
Fix test failures (#22058).
Add missing links to images in issue history (#22058).
History
#1
Updated by Jan from Planio www.plan.io over 6 years ago
- Description updated (diff)
#2
Updated by Jan from Planio www.plan.io over 6 years ago
- File image_preview_in_redmine.jpg added
- File 0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch added
- File 0002-Whitespace-only-change.patch added
- File 0003-Add-inline-image-preview-display-for-attachments-and.patch added
- File 0004-Whitespace-only.patch added
- Assignee deleted (
Jan from Planio www.plan.io) - Target version set to Candidate for next minor release
Here's a patch series that adds this feature:
#3
Updated by Jan from Planio www.plan.io over 6 years ago
- File deleted (
0003-Add-inline-image-preview-display-for-attachments-and.patch)
#4
Updated by Jan from Planio www.plan.io over 6 years ago
Rebasing patch onto current trunk.
#5
Updated by Go MAEDA over 6 years ago
- Target version changed from Candidate for next minor release to 3.3.0
#6
Updated by Jean-Philippe Lang over 6 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
#7
Updated by Krzysztof Zielonka over 5 years ago
Is any reason to use download_named_attachment_url in app/views/attachments/image.html.erb instead download_named_attachment_path?
#8
Updated by Toshi MARUYAMA over 5 years ago
Krzysztof Zielonka wrote:
Is any reason to use download_named_attachment_url in app/views/attachments/image.html.erb instead download_named_attachment_path?
FTR: #25295