Defect #22583

CSV import delimiter detection broken

Added by Jan from Planio www.plan.io over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:3.2.2
Resolution:Fixed Affected version:3.2.1

Description

When uploading a CSV file to import, the delimiter used in the CSV is supposed to be auto-detected.

However, File.read seems to not be used properly: The third parameter may not be a string.

This is rescued in the block and therefore, the user does not see the error. However, the auto-detection does not work.

Attached is a simple patch that fixes this.

fix_csv_autodetection.patch Magnifier (484 Bytes) Jan from Planio www.plan.io, 2016-04-19 16:38

Associated revisions

Revision 15357
Added by Jean-Philippe Lang over 2 years ago

CSV import delimiter detection broken (#22583).

Patch by Jan Schulz-Hofen.

History

#1 Updated by Go MAEDA over 2 years ago

  • Status changed from Needs feedback to New
  • Target version changed from Candidate for next minor release to 3.2.2

Thanks for the patch. Setting target version to 3.2.2.

#2 Updated by Go MAEDA over 2 years ago

  • Resolution deleted (Fixed)

#3 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

Also available in: Atom PDF