Project

General

Profile

Actions
Copy link

Patch #23388

closed

German translation change

Added by Anonymous about 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toshi MARUYAMA
Category:
Translations
Target version:
3.4.0

Description

Added several missing translations, fixed typos and changed the translation of repository "Projektarchiv", which led to significant confusion in relation to archives.

Files

Download all files
config_de.yml (56.6 KB) config_de.yml Anonymous, 2016-07-20 10:53
de-update-23388.diff (12.9 KB) de-update-23388.diff Go MAEDA, 2016-07-20 15:23
de-update-23388_rev2.diff (12.7 KB) de-update-23388_rev2.diff revision 2 Tobias Fischer, 2016-07-25 09:52

Related issues

Copied to Redmine - Patch #23725: Updated Brazilian translation for 3.3.0.stableClosedActions
Actions
Copy link
 #1

Updated by Go MAEDA about 10 years ago

Generated patch from JW Fuchs's config_de.yml: de-update-23388.diff
Could anyone who understand the German language review this?

Actions
Copy link
 #2

Updated by Tobias Fischer about 10 years ago

Looks good to me!

However, please don't change the label "label_day_plural"!

Tage is perfectly well! Example:
  • Duration: 2 days – Dauer: 2 Tage
The proposed change Tagen is used in other context:
  • In/Since 2 days – In/Seit 2 Tagen

But I don't think that this grammatical issue can be distinguished by Redmine at the moment. So I would stick to the "normal" plural form.

Actions
Copy link
 #3

Updated by Anonymous about 10 years ago

Tobias Fischer wrote:

Looks good to me!

However, please don't change the label "label_day_plural"!

Tage is perfectly well! Example:
  • Duration: 2 days – Dauer: 2 Tage
The proposed change Tagen is used in other context:
  • In/Since 2 days – In/Seit 2 Tagen

But I don't think that this grammatical issue can be distinguished by Redmine at the moment. So I would stick to the "normal" plural form.

Understood, this label change is not necessary. We had some users at our company complain about this minor issue so I suggested this change. We did not come across the use as in "since x days" as we're not using the time tracking module.

Actions
Copy link
 #4

Updated by Tobias Fischer about 10 years ago

Alright.

I updated the patch and removed the proposed change for label_day_plural

I also changed another string on the fly:

     [old] notice_failed_to_save_time_entries: "Gescheitert %{count} Zeiteinträge für %{total} von ausgewählten: %{ids} zu speichern." 
[proposed] notice_failed_to_save_time_entries: "Gescheitert %{count} Zeiteinträge für %{total} von ausgewählten %{ids} zu speichern." 
   [final] notice_failed_to_save_time_entries: "%{count} von %{total} ausgewählten Zeiteinträgen konnte(n) nicht gespeichert werden: %{ids}"

My [final] change was made to align the failure notice with the other notice for tickets:

notice_failed_to_save_issues: "%{count} von %{total} ausgewählten Tickets konnte(n) nicht gespeichert werden: %{ids}."

IMHO, this sounds a lot better...

Actions
Copy link
 #5

Updated by Go MAEDA about 10 years ago

  • Target version set to 3.3.1

Tobias Fischer, thanks for reviewing this patch.
Setting target version to 3.3.1.

Actions
Copy link
 #6

Updated by Luiz Moura about 10 years ago

  • Copied to Patch #23725: Updated Brazilian translation for 3.3.0.stable added
Actions
Copy link
 #7

Updated by Toshi MARUYAMA about 10 years ago

  • Target version changed from 3.3.1 to 3.4.0
Actions
Copy link
 #8

Updated by Toshi MARUYAMA about 10 years ago

  • Subject changed from Updated German translation for 3.3.0.stable to German translation change
Actions
Copy link
 #9

Updated by Luka Lüdicke almost 10 years ago

Hey, while on the subject of german translations - could you change the the label_me for the assignee selection from

ich to mich (Zugewiesen an: ich is grammatically incorrect)

Actions
Copy link
 #10

Updated by Jan from Planio www.plan.io almost 10 years ago

Luka Lüdicke wrote:

Hey, while on the subject of german translations - could you change the the label_me for the assignee selection from

ich to mich (Zugewiesen an: ich is grammatically incorrect)

I haven't checked yet myself, but we need to make sure that label_me isn't used in any other context througout the code where "ich" would be more appropriate. In that case we would have just improved one place while making other(s) worse :)

Actions
Copy link
 #11

Updated by Philipp Prangenberg almost 10 years ago

Hello,

in my opinion, the seperator and delimiter have to be changed. In Germany you write down numbers the other way.

So this one:

  number:
    # Default format for numbers
    format:
      separator: ','
      delimiter: '.'

needs to be changed to this one:
  number:
    # Default format for numbers
    format:
      separator: '.'
      delimiter: ','

Technically you have to use a space ' ' as separator, because the dot '.' is only used in currency. But the space is not that common like the dot.

https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html

Actions
Copy link
 #12

Updated by Jan from Planio www.plan.io almost 10 years ago

Philipp Prangenberg wrote:

Hello,

in my opinion, the seperator and delimiter have to be changed. In Germany you write down numbers the other way.

Hello and welcome to Redmine :-) Please open a new issue for every bug or feature request. If you add a new bug report to an existing issue, it becomes incredibly hard to keep track.

To respond to your request: In Rails, the delimiter separates thousands and the separator separates integer and fractional part (some call it the radix point), see http://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html.

Therefore, the values for the German locale are correct as they are in Redmine and don't need changing.

Actions
Copy link
 #13

Updated by Jean-Philippe Lang over 9 years ago

  • Assignee set to Toshi MARUYAMA

Toshi, more stuff needs to be committed or can we close? Thanks.

Actions
Copy link
 #14

Updated by Toshi MARUYAMA over 9 years ago

  • Status changed from New to Closed

No more commits.

Actions
Copy link

Also available in: Atom PDF