Patch #23388

German translation change

Added by JW Fuchs about 1 year ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Toshi MARUYAMA% Done:

0%

Category:Translations
Target version:3.4.0

Description

Added several missing translations, fixed typos and changed the translation of repository "Projektarchiv", which led to significant confusion in relation to archives.

config_de.yml Magnifier (56.6 KB) JW Fuchs, 2016-07-20 10:53

de-update-23388.diff Magnifier (12.9 KB) Go MAEDA, 2016-07-20 15:23

de-update-23388_rev2.diff Magnifier - revision 2 (12.7 KB) Tobias Fischer, 2016-07-25 09:52


Related issues

Copied to Redmine - Patch #23725: Updated Brazilian translation for 3.3.0.stable Closed

Associated revisions

Revision 15800
Added by Toshi MARUYAMA about 1 year ago

German translation for 3.1-stable updated by JW Fuchs (#23388, #23744)

Revision 15801
Added by Toshi MARUYAMA about 1 year ago

German translation for 3.3-stable updated by JW Fuchs (#23388, #23745)

Revision 15806
Added by Toshi MARUYAMA about 1 year ago

Merged r15800 from trunk to 3.3-stable (#23388, #23744)

German translation for 3.1-stable updated by JW Fuchs.

Revision 15807
Added by Toshi MARUYAMA about 1 year ago

Merged r15801 from trunk to 3.3-stable (#23388, #23745)

German translation for 3.3-stable updated by JW Fuchs.

Revision 15808
Added by Toshi MARUYAMA about 1 year ago

Merged r15800 from trunk to 3.2-stable (#23388, #23744)

German translation for 3.1-stable updated by JW Fuchs.

Revision 15809
Added by Toshi MARUYAMA about 1 year ago

Merged r15800 from trunk to 3.1-stable (#23388, #23744)

German translation for 3.1-stable updated by JW Fuchs.

Revision 16035
Added by Toshi MARUYAMA 10 months ago

German "repository" translation changed by JW Fuchs (#23388)

Revision 16036
Added by Toshi MARUYAMA 10 months ago

German translation changed by JW Fuchs (#23388)

Revision 16037
Added by Toshi MARUYAMA 10 months ago

German "notice_failed_to_save_time_entries" translation changed by Tobias Fischer (#23388)

History

#1 Updated by Go MAEDA about 1 year ago

Generated patch from JW Fuchs's config_de.yml: de-update-23388.diff
Could anyone who understand the German language review this?

#2 Updated by Tobias Fischer about 1 year ago

Looks good to me!

However, please don't change the label "label_day_plural"!

Tage is perfectly well! Example:
  • Duration: 2 days – Dauer: 2 Tage
The proposed change Tagen is used in other context:
  • In/Since 2 days – In/Seit 2 Tagen

But I don't think that this grammatical issue can be distinguished by Redmine at the moment. So I would stick to the "normal" plural form.

#3 Updated by JW Fuchs about 1 year ago

Tobias Fischer wrote:

Looks good to me!

However, please don't change the label "label_day_plural"!

Tage is perfectly well! Example:
  • Duration: 2 days – Dauer: 2 Tage
The proposed change Tagen is used in other context:
  • In/Since 2 days – In/Seit 2 Tagen

But I don't think that this grammatical issue can be distinguished by Redmine at the moment. So I would stick to the "normal" plural form.

Understood, this label change is not necessary. We had some users at our company complain about this minor issue so I suggested this change. We did not come across the use as in "since x days" as we're not using the time tracking module.

#4 Updated by Tobias Fischer about 1 year ago

Alright.

I updated the patch and removed the proposed change for label_day_plural

I also changed another string on the fly:

     [old] notice_failed_to_save_time_entries: "Gescheitert %{count} Zeiteinträge für %{total} von ausgewählten: %{ids} zu speichern." 
[proposed] notice_failed_to_save_time_entries: "Gescheitert %{count} Zeiteinträge für %{total} von ausgewählten %{ids} zu speichern." 
   [final] notice_failed_to_save_time_entries: "%{count} von %{total} ausgewählten Zeiteinträgen konnte(n) nicht gespeichert werden: %{ids}" 

My [final] change was made to align the failure notice with the other notice for tickets:

notice_failed_to_save_issues: "%{count} von %{total} ausgewählten Tickets konnte(n) nicht gespeichert werden: %{ids}." 

IMHO, this sounds a lot better...

#5 Updated by Go MAEDA about 1 year ago

  • Target version set to 3.3.1

Tobias Fischer, thanks for reviewing this patch.
Setting target version to 3.3.1.

#6 Updated by Luiz Moura about 1 year ago

  • Copied to Patch #23725: Updated Brazilian translation for 3.3.0.stable added

#7 Updated by Toshi MARUYAMA about 1 year ago

  • Target version changed from 3.3.1 to 3.4.0

#8 Updated by Toshi MARUYAMA about 1 year ago

  • Subject changed from Updated German translation for 3.3.0.stable to German translation change

#9 Updated by Luka Lüdicke 11 months ago

Hey, while on the subject of german translations - could you change the the label_me for the assignee selection from

ich to mich (Zugewiesen an: ich is grammatically incorrect)

#10 Updated by Jan from Planio www.plan.io 11 months ago

Luka Lüdicke wrote:

Hey, while on the subject of german translations - could you change the the label_me for the assignee selection from

ich to mich (Zugewiesen an: ich is grammatically incorrect)

I haven't checked yet myself, but we need to make sure that label_me isn't used in any other context througout the code where "ich" would be more appropriate. In that case we would have just improved one place while making other(s) worse :)

#11 Updated by Philipp Prangenberg 10 months ago

Hello,

in my opinion, the seperator and delimiter have to be changed. In Germany you write down numbers the other way.

So this one:

  number:
    # Default format for numbers
    format:
      separator: ','
      delimiter: '.'

needs to be changed to this one:
  number:
    # Default format for numbers
    format:
      separator: '.'
      delimiter: ','

Technically you have to use a space ' ' as separator, because the dot '.' is only used in currency. But the space is not that common like the dot.

https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html

#12 Updated by Jan from Planio www.plan.io 10 months ago

Philipp Prangenberg wrote:

Hello,

in my opinion, the seperator and delimiter have to be changed. In Germany you write down numbers the other way.

Hello and welcome to Redmine :-) Please open a new issue for every bug or feature request. If you add a new bug report to an existing issue, it becomes incredibly hard to keep track.

To respond to your request: In Rails, the delimiter separates thousands and the separator separates integer and fractional part (some call it the radix point), see http://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html.

Therefore, the values for the German locale are correct as they are in Redmine and don't need changing.

#13 Updated by Jean-Philippe Lang 7 months ago

  • Assignee set to Toshi MARUYAMA

Toshi, more stuff needs to be committed or can we close? Thanks.

#14 Updated by Toshi MARUYAMA 7 months ago

  • Status changed from New to Closed

No more commits.

Also available in: Atom PDF